Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 2344813003: Correct flowThreadTranslationAtOffset() for vertical-rl writing mode. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/offset-top-and-left-nested.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
index 72000539f6d00ba8935a318a64f18ee079697b88..b992f1ba0e910c7ba857d00ef63beb29217b8327 100644
--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
@@ -110,10 +110,14 @@ LayoutSize MultiColumnFragmentainerGroup::flowThreadTranslationAtOffset(LayoutUn
LayoutRect portionRect(flowThreadPortionRectAt(columnIndex));
flowThread->flipForWritingMode(portionRect);
+ portionRect.moveBy(flowThread->topLeftLocation());
+
LayoutRect columnRect(columnRectAt(columnIndex));
+ columnRect.move(offsetFromColumnSet());
m_columnSet.flipForWritingMode(columnRect);
- LayoutSize translationRelativeToGroup = columnRect.location() - portionRect.location();
- LayoutSize translationRelativeToFlowThread = translationRelativeToGroup + offsetFromColumnSet() + m_columnSet.topLeftLocationOffset() - flowThread->topLeftLocationOffset();
+ columnRect.moveBy(m_columnSet.topLeftLocation());
+
+ LayoutSize translationRelativeToFlowThread = columnRect.location() - portionRect.location();
if (mode == CoordinateSpaceConversion::Containing)
return translationRelativeToFlowThread;
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/offset-top-and-left-nested.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698