MD WebUI: Simplify usage of Templatizer in cr-lazy-render

MD WebUI: Simplify usage of Templatizer in cr-lazy-render

This changes the template stamping parts of cr-lazy-render to look more
like iron-list. This simplifies the code and makes it play nicely with
Closure.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/896eeb353419d5dc54facc98453bddf274573eca
Cr-Commit-Position: refs/heads/master@{#419058}

[tsergeant, 2016-09-15 05:11:48]

Description was changed from

==========
MD WebUI: Simplify usage of Templatizer in cr-lazy-render

This changes the template stamping parts of cr-lazy-render to look more
like iron-list. This simplifies the code and makes it play nicely with
Closure.

BUG=642200
==========

to

==========
MD WebUI: Simplify usage of Templatizer in cr-lazy-render

This changes the template stamping parts of cr-lazy-render to look more
like iron-list. This simplifies the code and makes it play nicely with
Closure.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-09-15 05:42:09]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 05:42:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 06:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 06:32:01]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-09-15 07:53:44]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-09-15 08:44:41]

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js (right):

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:66: this._child
= instance.root.querySelector('*');
instance.root.firstElementChild

[Dan Beam, 2016-09-15 17:19:00]

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js (right):

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:31: _child:
null,
use trailing underscore for Chrome JS unless it has to @override something, i.e.

renderPromise_
child_

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:59: /** @private
*/
is this actually private or @protected in polymer terminology?

[tsergeant, 2016-09-15 23:26:49]

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js (right):

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:31: _child:
null,
On 2016/09/15 17:19:00, Dan Beam wrote:
> use trailing underscore for Chrome JS unless it has to @override something,
i.e.
> 
> renderPromise_
> child_

I was originally trying to avoid things like `instance_._children` which was
confusing to write and read.

This CL cleans up several of those cases, so I've made the switch back to
trailing underscores.

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:59: /** @private
*/
On 2016/09/15 17:19:00, Dan Beam wrote:
> is this actually private or @protected in polymer terminology?

It's private, yeah. Nothing else should be using it.

https://codereview.chromium.org/2344803002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:66: this._child
= instance.root.querySelector('*');
On 2016/09/15 08:44:41, michaelpg wrote:
> instance.root.firstElementChild

Done.

[Dan Beam, 2016-09-15 23:37:05]

lgtm

[tsergeant, 2016-09-15 23:43:35]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 00:39:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 00:42:53]

Description was changed from

==========
MD WebUI: Simplify usage of Templatizer in cr-lazy-render

This changes the template stamping parts of cr-lazy-render to look more
like iron-list. This simplifies the code and makes it play nicely with
Closure.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Simplify usage of Templatizer in cr-lazy-render

This changes the template stamping parts of cr-lazy-render to look more
like iron-list. This simplifies the code and makes it play nicely with
Closure.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/896eeb353419d5dc54facc98453bddf274573eca
Cr-Commit-Position: refs/heads/master@{#419058}
==========

[commit-bot: I haz the power, 2016-09-16 00:42:57]

Patchset 3 (id:??) landed as
https://crrev.com/896eeb353419d5dc54facc98453bddf274573eca
Cr-Commit-Position: refs/heads/master@{#419058}