MD WebUI: Make cr-lazy-render get() synchronous

MD WebUI: Make cr-lazy-render get() synchronous

dom-if and similar stamp their templates asynchronously, because it's
not a great idea to block execution to stamp out DOM as a result of
changes to properties. cr-lazy-render does not really share the same
concerns: it will only stamp when explicitly told to, and the caller
should be aware of how long this could take. As such, there is no
particular reason to prefer async stamping.

This CL changes all existing usage of cr-lazy-render to be synchronous,
which simplifies both application code and tests. An asynchronous API
could still be added in the future, if required.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cede888c27275835e5aaadf5dac49379eb3ac106
Cr-Commit-Position: refs/heads/master@{#419407}

[tsergeant, 2016-09-16 04:09:50]

Description was changed from

==========
MD WebUI: Make cr-lazy-render get() synchronous

dom-if and similar stamp their templates asynchronously, because it's
not a great idea to block execution to stamp out DOM as a result of
changes to properties. cr-lazy-render does not really share the same
concerns: it will only stamp when explicitly told to, and the caller
should be aware of how long this could take. As such, there is no
particular reason to prefer async stamping.

This CL changes all existing usage of cr-lazy-render to be synchronous,
which simplifies both application code and tests. An asynchronous API
could still be added in the future, if required.

BUG=642200
==========

to

==========
MD WebUI: Make cr-lazy-render get() synchronous

dom-if and similar stamp their templates asynchronously, because it's
not a great idea to block execution to stamp out DOM as a result of
changes to properties. cr-lazy-render does not really share the same
concerns: it will only stamp when explicitly told to, and the caller
should be aware of how long this could take. As such, there is no
particular reason to prefer async stamping.

This CL changes all existing usage of cr-lazy-render to be synchronous,
which simplifies both application code and tests. An asynchronous API
could still be added in the future, if required.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-09-16 04:16:07]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 04:16:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 05:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 05:06:03]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-09-16 06:40:41]

tsergeant@chromium.org changed reviewers:
+ michaelpg@chromium.org

[tsergeant, 2016-09-16 06:40:42]

As discussed, PTAL

[michaelpg, 2016-09-16 23:18:41]

lgtm

https://codereview.chromium.org/2341923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2341923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:137: var menu =
this.$.menu.get();
/** @type {CrSharedMenuElement} */

[tsergeant, 2016-09-19 00:39:18]

https://codereview.chromium.org/2341923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2341923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:137: var menu =
this.$.menu.get();
On 2016/09/16 23:18:40, michaelpg wrote:
> /** @type {CrSharedMenuElement} */

Done.

[tsergeant, 2016-09-19 00:39:41]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-09-19 00:39:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2341923005/#ps40001
(title: "Closure")

[commit-bot: I haz the power, 2016-09-19 00:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 00:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 00:42:24]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tsergeant, 2016-09-19 00:49:11]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-09-19 00:49:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2341923005/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-19 00:49:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 01:55:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 01:57:16]

Description was changed from

==========
MD WebUI: Make cr-lazy-render get() synchronous

dom-if and similar stamp their templates asynchronously, because it's
not a great idea to block execution to stamp out DOM as a result of
changes to properties. cr-lazy-render does not really share the same
concerns: it will only stamp when explicitly told to, and the caller
should be aware of how long this could take. As such, there is no
particular reason to prefer async stamping.

This CL changes all existing usage of cr-lazy-render to be synchronous,
which simplifies both application code and tests. An asynchronous API
could still be added in the future, if required.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Make cr-lazy-render get() synchronous

dom-if and similar stamp their templates asynchronously, because it's
not a great idea to block execution to stamp out DOM as a result of
changes to properties. cr-lazy-render does not really share the same
concerns: it will only stamp when explicitly told to, and the caller
should be aware of how long this could take. As such, there is no
particular reason to prefer async stamping.

This CL changes all existing usage of cr-lazy-render to be synchronous,
which simplifies both application code and tests. An asynchronous API
could still be added in the future, if required.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cede888c27275835e5aaadf5dac49379eb3ac106
Cr-Commit-Position: refs/heads/master@{#419407}
==========

[commit-bot: I haz the power, 2016-09-19 01:57:17]

Patchset 4 (id:??) landed as
https://crrev.com/cede888c27275835e5aaadf5dac49379eb3ac106
Cr-Commit-Position: refs/heads/master@{#419407}