Issue 23448003: aura: Don't Show() a newly created RenderWidgetHostView() for a hidden RenderWidgetHost.

Issue 23448003: aura: Don't Show() a newly created RenderWidgetHostView() for a hidden RenderWidgetHost. (Closed)

Created:
7 years, 3 months ago by sadrul

Modified:
7 years, 3 months ago

Reviewers:
Charlie Reis, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

aura: Don't Show() a newly created RenderWidgetHostView() for a hidden RenderWidgetHost. BUG=284817 R=creis@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221771

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	content/browser/web_contents/web_contents_view_aura.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 8 (0 generated)

Charlie Reis

LGTM, but I'm not clear which behavior ends up affected by the change. Can you ...

7 years, 3 months ago (2013-08-26 23:28:41 UTC) #2

sadrul

On 2013/08/26 23:28:41, creis wrote: > LGTM, but I'm not clear which behavior ends up ...

7 years, 3 months ago (2013-09-03 23:29:18 UTC) #3

sadrul

On 2013/09/04 14:11:58, sky wrote: > This seems right. Do the other platforms do similar? ...

7 years, 3 months ago (2013-09-04 15:25:12 UTC) #5

sadrul

On 2013/09/04 15:25:12, sadrul wrote: > On 2013/09/04 14:11:58, sky wrote: > > This seems ...

7 years, 3 months ago (2013-09-05 20:41:48 UTC) #6

sadrul

7 years, 3 months ago (2013-09-06 20:33:18 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 manually as r221771 (presubmit successful).