Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 23448003: aura: Don't Show() a newly created RenderWidgetHostView() for a hidden RenderWidgetHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index 043efca119ab19182f44b386ac8509aebb75a81f..dee120eb102ded6d9a7b23dd334d6448f61b73b7 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -1169,13 +1169,15 @@ RenderWidgetHostView* WebContentsViewAura::CreateViewForWidget(
navigation_overlay_->StartObservingView(ToRenderWidgetHostViewAura(view));
}
- view->Show();
+ RenderWidgetHostImpl* host_impl =
+ RenderWidgetHostImpl::From(render_widget_host);
+
+ if (!host_impl->is_hidden())
+ view->Show();
// We listen to drag drop events in the newly created view's window.
aura::client::SetDragDropDelegate(view->GetNativeView(), this);
- RenderWidgetHostImpl* host_impl =
- RenderWidgetHostImpl::From(render_widget_host);
if (host_impl->overscroll_controller() &&
(!web_contents_->GetDelegate() ||
web_contents_->GetDelegate()->CanOverscrollContent())) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698