Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5990)

Unified Diff: chrome/renderer/BUILD.gn

Issue 2344783004: Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/BUILD.gn
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
index dc4067cc62afacd713599e560d7f09a70c6ba76b..ead9e32bba736959851fcdfbcc27de2eb3afb553 100644
--- a/chrome/renderer/BUILD.gn
+++ b/chrome/renderer/BUILD.gn
@@ -224,10 +224,6 @@ static_library("renderer") {
"extensions/chrome_v8_extension_handler.h",
"extensions/extension_localization_peer.cc",
"extensions/extension_localization_peer.h",
- "extensions/file_browser_handler_custom_bindings.cc",
- "extensions/file_browser_handler_custom_bindings.h",
- "extensions/file_manager_private_custom_bindings.cc",
- "extensions/file_manager_private_custom_bindings.h",
"extensions/media_galleries_custom_bindings.cc",
"extensions/media_galleries_custom_bindings.h",
"extensions/notifications_native_handler.cc",
@@ -274,9 +270,7 @@ static_library("renderer") {
"resources/extensions/declarative_content_custom_bindings.js",
"resources/extensions/enterprise_platform_keys_custom_bindings.js",
"resources/extensions/feedback_private_custom_bindings.js",
- "resources/extensions/file_browser_handler_custom_bindings.js",
"resources/extensions/file_entry_binding_util.js",
- "resources/extensions/file_manager_private_custom_bindings.js",
"resources/extensions/file_system_custom_bindings.js",
"resources/extensions/file_system_provider_custom_bindings.js",
"resources/extensions/gcm_custom_bindings.js",
@@ -292,6 +286,16 @@ static_library("renderer") {
"resources/extensions/tts_custom_bindings.js",
"resources/extensions/tts_engine_custom_bindings.js",
]
+ if (is_chromeos) {
sky 2016/09/16 21:18:33 Move this to the is_chromeos section on line 353 (
lazyboy 2016/09/16 22:07:22 Moved, but does is_chromeos imply enable_extension
+ sources += [
+ "extensions/file_browser_handler_custom_bindings.cc",
lazyboy 2016/09/15 23:20:13 Is this the right way? I can compile and run linux
Devlin 2016/09/16 00:35:48 I think this is fine. Soon, these will go in c/r/
+ "extensions/file_browser_handler_custom_bindings.h",
+ "extensions/file_manager_private_custom_bindings.cc",
+ "extensions/file_manager_private_custom_bindings.h",
+ "resources/extensions/file_browser_handler_custom_bindings.js",
+ "resources/extensions/file_manager_private_custom_bindings.js",
+ ]
+ }
deps += [
# TODO(hclam): See crbug.com/298380 for details.
# We should isolate the APIs needed by the renderer.
« no previous file with comments | « no previous file | chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698