Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only.

chrome/renderer/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//tools/grit/grit_rule.gni")
 
 # GYP version: chrome/chrome_resources.gyp:chrome_resources
 # (generate_renderer_resources action)
 grit("resources") {
@@ skipping 206 matching lines @@
       "extensions/automation_internal_custom_bindings.cc",
       "extensions/automation_internal_custom_bindings.h",
       "extensions/chrome_extensions_dispatcher_delegate.cc",
       "extensions/chrome_extensions_dispatcher_delegate.h",
       "extensions/chrome_extensions_renderer_client.cc",
       "extensions/chrome_extensions_renderer_client.h",
       "extensions/chrome_v8_extension_handler.cc",
       "extensions/chrome_v8_extension_handler.h",
       "extensions/extension_localization_peer.cc",
       "extensions/extension_localization_peer.h",
-      "extensions/file_browser_handler_custom_bindings.cc",
-      "extensions/file_browser_handler_custom_bindings.h",
-      "extensions/file_manager_private_custom_bindings.cc",
-      "extensions/file_manager_private_custom_bindings.h",
       "extensions/media_galleries_custom_bindings.cc",
       "extensions/media_galleries_custom_bindings.h",
       "extensions/notifications_native_handler.cc",
       "extensions/notifications_native_handler.h",
       "extensions/page_capture_custom_bindings.cc",
       "extensions/page_capture_custom_bindings.h",
       "extensions/platform_keys_natives.cc",
       "extensions/platform_keys_natives.h",
       "extensions/renderer_permissions_policy_delegate.cc",
       "extensions/renderer_permissions_policy_delegate.h",
@@ skipping 26 matching lines @@
       "resources/extensions/app_custom_bindings.js",
       "resources/extensions/automation_custom_bindings.js",
       "resources/extensions/browser_action_custom_bindings.js",
       "resources/extensions/certificate_provider_custom_bindings.js",
       "resources/extensions/chrome_direct_setting.js",
       "resources/extensions/chrome_setting.js",
       "resources/extensions/content_setting.js",
       "resources/extensions/declarative_content_custom_bindings.js",
       "resources/extensions/enterprise_platform_keys_custom_bindings.js",
       "resources/extensions/feedback_private_custom_bindings.js",
-      "resources/extensions/file_browser_handler_custom_bindings.js",
       "resources/extensions/file_entry_binding_util.js",
-      "resources/extensions/file_manager_private_custom_bindings.js",
       "resources/extensions/file_system_custom_bindings.js",
       "resources/extensions/file_system_provider_custom_bindings.js",
       "resources/extensions/gcm_custom_bindings.js",
       "resources/extensions/identity_custom_bindings.js",
       "resources/extensions/image_writer_private_custom_bindings.js",
       "resources/extensions/input.ime_custom_bindings.js",
       "resources/extensions/log_private_custom_bindings.js",
       "resources/extensions/notifications_custom_bindings.js",
       "resources/extensions/omnibox_custom_bindings.js",
       "resources/extensions/page_action_custom_bindings.js",
       "resources/extensions/page_capture_custom_bindings.js",
       "resources/extensions/system_indicator_custom_bindings.js",
       "resources/extensions/tts_custom_bindings.js",
       "resources/extensions/tts_engine_custom_bindings.js",
     ]
+    if (is_chromeos) {

[sky, 2016/09/16 21:18:33]

Move this to the is_chromeos section on line 353 (new).

[lazyboy, 2016/09/16 22:07:22]

Moved, but does is_chromeos imply enable_extensions? i.e. is if
(enable_extensions) check redundant in the new code?

+      sources += [
+        "extensions/file_browser_handler_custom_bindings.cc",

[lazyboy, 2016/09/15 23:20:13]

Is this the right way? I can compile and run linux desktop and chromeos desktop
fine.

Also, there aren't any chromeos directory in the renderer/ code, do we need to
put these under a chromeos/ dir?

[Devlin, 2016/09/16 00:35:48]

I think this is fine.  Soon, these will go in c/r/e/BUILD.gn, and it will be
more apparent, but this is good for now.  There shouldn't be a need to make a
chromeos only dir.

+        "extensions/file_browser_handler_custom_bindings.h",
+        "extensions/file_manager_private_custom_bindings.cc",
+        "extensions/file_manager_private_custom_bindings.h",
+        "resources/extensions/file_browser_handler_custom_bindings.js",
+        "resources/extensions/file_manager_private_custom_bindings.js",
+      ]
+    }
     deps += [
       # TODO(hclam): See crbug.com/298380 for details.
       # We should isolate the APIs needed by the renderer.
       "//chrome/common/extensions/api",
       "//extensions:extensions_resources",
       "//extensions/renderer",
       "//media/cast:net",
       "//media/cast:receiver",
       "//media/cast:sender",
     ]
@@ skipping 78 matching lines @@
     ]
   }
 
   if (is_android) {
     sources -= [
       "safe_browsing/mock_feature_extractor_clock.cc",
       "safe_browsing/mock_feature_extractor_clock.h",
     ]
   }
 }