Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only.

Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only.

This is because they are only available/needed on chromeos.

On my local test setup, I see a reduction of 6672 bytes in chrome binary:

gn gen out/Release --args=' use_goma=true is_clang=true \
is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" \
safe_browsing_mode=1 enable_google_now=true is_debug=false \
dcheck_always_on=true '

ninja -C out/Release chrome

With this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61439904 Sep 15 16:03 out/Release/chrome
Without this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61446576 Sep 15 16:04 out/Release/chrome

BUG=376319
Test=Expect no visible change.

Committed: https://crrev.com/6e2eae19d7a198803699abc3c0532c0c66d1e060
Cr-Commit-Position: refs/heads/master@{#419356}

[lazyboy, 2016-09-15 23:20:12]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[lazyboy, 2016-09-15 23:20:13]

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn
File chrome/renderer/BUILD.gn (right):

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn#ne...
chrome/renderer/BUILD.gn:291:
"extensions/file_browser_handler_custom_bindings.cc",
Is this the right way? I can compile and run linux desktop and chromeos desktop
fine.

Also, there aren't any chromeos directory in the renderer/ code, do we need to
put these under a chromeos/ dir?

[Devlin, 2016-09-16 00:35:48]

lgtm as long as the bots pass

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn
File chrome/renderer/BUILD.gn (right):

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn#ne...
chrome/renderer/BUILD.gn:291:
"extensions/file_browser_handler_custom_bindings.cc",
On 2016/09/15 23:20:13, lazyboy wrote:
> Is this the right way? I can compile and run linux desktop and chromeos
desktop
> fine.
> 
> Also, there aren't any chromeos directory in the renderer/ code, do we need to
> put these under a chromeos/ dir?

I think this is fine.  Soon, these will go in c/r/e/BUILD.gn, and it will be
more apparent, but this is good for now.  There shouldn't be a need to make a
chromeos only dir.

[lazyboy, 2016-09-16 00:49:21]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 00:49:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 02:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:49:10]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-09-16 17:10:01]

lazyboy@chromium.org changed reviewers:
+ sky@chromium.org

[lazyboy, 2016-09-16 17:10:02]

+sky for OWNERS review.

[sky, 2016-09-16 21:18:33]

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn
File chrome/renderer/BUILD.gn (right):

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn#ne...
chrome/renderer/BUILD.gn:289: if (is_chromeos) {
Move this to the is_chromeos section on line 353 (new).

[lazyboy, 2016-09-16 22:07:22]

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn
File chrome/renderer/BUILD.gn (right):

https://codereview.chromium.org/2344783004/diff/1/chrome/renderer/BUILD.gn#ne...
chrome/renderer/BUILD.gn:289: if (is_chromeos) {
On 2016/09/16 21:18:33, sky wrote:
> Move this to the is_chromeos section on line 353 (new).

Moved, but does is_chromeos imply enable_extensions? i.e. is if
(enable_extensions) check redundant in the new code?

[sky, 2016-09-16 23:05:05]

I don't believe chromeos works without extensions:
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/chrome...
.

[lazyboy, 2016-09-16 23:10:15]

On 2016/09/16 23:05:05, sky wrote:
> I don't believe chromeos works without extensions:
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/chrome...
> .

Thanks, removed the "if (enable_extensions)" check.

[sky, 2016-09-16 23:22:38]

LGTM

[lazyboy, 2016-09-16 23:30:17]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:30:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 00:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 00:34:04]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-09-17 00:59:29]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-09-17 00:59:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2344783004/#ps40001
(title: "-amremove enable_extensions check")

[commit-bot: I haz the power, 2016-09-17 00:59:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:05:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-17 01:08:21]

Description was changed from

==========
Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only.

This is because they are only available/needed on chromeos.

On my local test setup, I see a reduction of 6672 bytes in chrome binary:

gn gen out/Release --args=' use_goma=true is_clang=true \
is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" \
safe_browsing_mode=1 enable_google_now=true is_debug=false \
dcheck_always_on=true '

ninja -C out/Release chrome

With this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61439904 Sep 15 16:03 out/Release/chrome
Without this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61446576 Sep 15 16:04 out/Release/chrome

BUG=376319
Test=Expect no visible change.
==========

to

==========
Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only.

This is because they are only available/needed on chromeos.

On my local test setup, I see a reduction of 6672 bytes in chrome binary:

gn gen out/Release --args=' use_goma=true is_clang=true \
is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" \
safe_browsing_mode=1 enable_google_now=true is_debug=false \
dcheck_always_on=true '

ninja -C out/Release chrome

With this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61439904 Sep 15 16:03 out/Release/chrome
Without this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61446576 Sep 15 16:04 out/Release/chrome

BUG=376319
Test=Expect no visible change.

Committed: https://crrev.com/6e2eae19d7a198803699abc3c0532c0c66d1e060
Cr-Commit-Position: refs/heads/master@{#419356}
==========

[commit-bot: I haz the power, 2016-09-17 01:08:22]

Patchset 3 (id:??) landed as
https://crrev.com/6e2eae19d7a198803699abc3c0532c0c66d1e060
Cr-Commit-Position: refs/heads/master@{#419356}