Reland of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.or…

Reland of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.or… (patchset #2 id:20001 of https://codereview.chromium.org/2112713003/ )

Reason for revert:
With fixes for frozen RegExps in https://codereview.chromium.org/2339443002 , it should be web-compatible to put RegExps in strict mode again, per spec.

Original issue's description:
> Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.org/1776883005/ )
>
> Reason for revert:
> Found to break SAP Web IDE, and these semantics are not shipped in any other browser.
> Revert to legacy semantics while assessing web compatibility.
>
> BUG=chromium:624318
>
> Original issue's description:
> > Put RegExp js code in strict mode
> >
> > src/js/regexp.js was one of the few files that was left in sloppy
> > mode. The ES2017 draft specification requires that writes to
> > lastIndex throw when the property is non-writable, and test262
> > tests enforce this behavior. This patch puts that file in strict
> > mode.
> >
> > BUG=v8:4504
> > R=yangguo@chromium.org
> > LOG=Y
> >
> > Committed: https://crrev.com/80b1b2a45bbd9bf3d08e4e6516acfaaa8f438213
> > Cr-Commit-Position: refs/heads/master@{#34801}
>
> TBR=yangguo@chromium.org,adamk@chromium.org
>
> Committed: https://crrev.com/34880eb3dcf7492d44c0a3b45b6c888189f2c3c3
> Cr-Commit-Position: refs/heads/master@{#37449}

TBR=adamk@chromium.org,yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:624318
Committed: https://crrev.com/6b7430fab1cac0b8b9d6a45b5fdd1ca252921ed7
Cr-Commit-Position: refs/heads/master@{#39456}

[Dan Ehrenberg, 2016-09-15 03:30:06]

Created Reland of Put RegExp js code in strict mode (patchset #2 id:20001 of
https://codereview.chromium.or…

[Dan Ehrenberg, 2016-09-15 03:30:15]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 03:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 03:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 03:32:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12736)

[Dan Ehrenberg, 2016-09-15 04:04:33]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 04:04:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-15 04:07:45]

littledan@chromium.org changed reviewers:
+ jgruber@chromium.org

[Dan Ehrenberg, 2016-09-15 04:15:34]

This caused web compatibility issues in the past, but jgruber's fix should
address those and allow us to comply with the spec. Thoughts?

[commit-bot: I haz the power, 2016-09-15 04:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 04:30:46]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-09-15 07:23:40]

On 2016/09/15 04:15:34, Dan Ehrenberg wrote:
> This caused web compatibility issues in the past, but jgruber's fix should
> address those and allow us to comply with the spec. Thoughts?

lgtm.
I also looked into relanding this yesterday, and it seems like the following
test262 tests can also be reenabled:

--- a/test/test262/test262.status
+++ b/test/test262/test262.status
@@ -107,18 +107,7 @@
 
   # https://bugs.chromium.org/p/v8/issues/detail?id=5360
   'built-ins/RegExp/prototype/Symbol.match/builtin-failure-set-lastindex-err':
[PASS, FAIL],
- 
'built-ins/RegExp/prototype/Symbol.match/builtin-failure-y-set-lastindex-err':
[PASS, FAIL],
- 
'built-ins/RegExp/prototype/Symbol.match/builtin-success-g-set-lastindex-err':
[SKIP],
- 
'built-ins/RegExp/prototype/Symbol.match/builtin-success-y-set-lastindex-err':
[PASS, FAIL],
-  'built-ins/RegExp/prototype/Symbol.match/g-init-lastindex-err': [PASS, FAIL],
-  'built-ins/RegExp/prototype/Symbol.match/g-match-empty-set-lastindex-err':
[PASS, FAIL],
-  'built-ins/RegExp/prototype/Symbol.match/y-fail-lastindex-no-write': [PASS,
FAIL],
-  'built-ins/RegExp/prototype/Symbol.replace/g-init-lastindex-err': [PASS,
FAIL],
-  'built-ins/RegExp/prototype/Symbol.replace/y-fail-lastindex-no-write': [PASS,
FAIL],
-  'built-ins/RegExp/prototype/Symbol.search/set-lastindex-init-err': [PASS,
FAIL],
   'built-ins/RegExp/prototype/Symbol.search/set-lastindex-restore-err': [PASS,
FAIL],
-  'built-ins/RegExp/prototype/exec/y-fail-lastindex-no-write': [PASS, FAIL],
-  'built-ins/RegExp/prototype/test/y-fail-lastindex-no-write': [PASS, FAIL],

[adamk, 2016-09-15 15:46:48]

lgtm (does this break any Blink tests?)

[Dan Ehrenberg, 2016-09-15 18:53:57]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-09-15 18:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2344773002/#ps140001
(title: "Simplify test262 expectations")

[commit-bot: I haz the power, 2016-09-15 18:54:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-15 18:54:41]

On 2016/09/15 at 15:46:48, adamk wrote:
> lgtm (does this break any Blink tests?)

Doesn't seem to make the blink trybot fail.

Incorporated jgruber's status file simplification, thanks!

[commit-bot: I haz the power, 2016-09-15 19:20:24]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-09-15 19:21:21]

Description was changed from

==========
Reland of Put RegExp js code in strict mode (patchset #2 id:20001 of
https://codereview.chromium.or… (patchset #2 id:20001 of
https://codereview.chromium.org/2112713003/ )

Reason for revert:
With fixes for frozen RegExps in https://codereview.chromium.org/2339443002 , it
should be web-compatible to put RegExps in strict mode again, per spec.

Original issue's description:
> Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of
https://codereview.chromium.org/1776883005/ )
> 
> Reason for revert:
> Found to break SAP Web IDE, and these semantics are not shipped in any other
browser.
> Revert to legacy semantics while assessing web compatibility.
> 
> BUG=chromium:624318
> 
> Original issue's description:
> > Put RegExp js code in strict mode
> >
> > src/js/regexp.js was one of the few files that was left in sloppy
> > mode. The ES2017 draft specification requires that writes to
> > lastIndex throw when the property is non-writable, and test262
> > tests enforce this behavior. This patch puts that file in strict
> > mode.
> >
> > BUG=v8:4504
> > R=yangguo@chromium.org
> > LOG=Y
> >
> > Committed: https://crrev.com/80b1b2a45bbd9bf3d08e4e6516acfaaa8f438213
> > Cr-Commit-Position: refs/heads/master@{#34801}
> 
> TBR=yangguo@chromium.org,adamk@chromium.org
> 
> Committed: https://crrev.com/34880eb3dcf7492d44c0a3b45b6c888189f2c3c3
> Cr-Commit-Position: refs/heads/master@{#37449}

TBR=adamk@chromium.org,yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:624318
==========

to

==========
Reland of Put RegExp js code in strict mode (patchset #2 id:20001 of
https://codereview.chromium.or… (patchset #2 id:20001 of
https://codereview.chromium.org/2112713003/ )

Reason for revert:
With fixes for frozen RegExps in https://codereview.chromium.org/2339443002 , it
should be web-compatible to put RegExps in strict mode again, per spec.

Original issue's description:
> Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of
https://codereview.chromium.org/1776883005/ )
>
> Reason for revert:
> Found to break SAP Web IDE, and these semantics are not shipped in any other
browser.
> Revert to legacy semantics while assessing web compatibility.
>
> BUG=chromium:624318
>
> Original issue's description:
> > Put RegExp js code in strict mode
> >
> > src/js/regexp.js was one of the few files that was left in sloppy
> > mode. The ES2017 draft specification requires that writes to
> > lastIndex throw when the property is non-writable, and test262
> > tests enforce this behavior. This patch puts that file in strict
> > mode.
> >
> > BUG=v8:4504
> > R=yangguo@chromium.org
> > LOG=Y
> >
> > Committed: https://crrev.com/80b1b2a45bbd9bf3d08e4e6516acfaaa8f438213
> > Cr-Commit-Position: refs/heads/master@{#34801}
>
> TBR=yangguo@chromium.org,adamk@chromium.org
>
> Committed: https://crrev.com/34880eb3dcf7492d44c0a3b45b6c888189f2c3c3
> Cr-Commit-Position: refs/heads/master@{#37449}

TBR=adamk@chromium.org,yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:624318

Committed: https://crrev.com/6b7430fab1cac0b8b9d6a45b5fdd1ca252921ed7
Cr-Commit-Position: refs/heads/master@{#39456}
==========

[commit-bot: I haz the power, 2016-09-15 19:21:22]

Patchset 3 (id:??) landed as
https://crrev.com/6b7430fab1cac0b8b9d6a45b5fdd1ca252921ed7
Cr-Commit-Position: refs/heads/master@{#39456}