Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2344703003: GpuVideoDecoder now propagates errors during Flush() (Closed)

Created:
4 years, 3 months ago by watk
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GpuVideoDecoder now propagates errors during Flush() Previously it was possible for GVD to be processing a Flush() but not have no outstanding bitstream buffers in the VDA when it received a NotifyError(). For example, when decoding single frame videos. In that case it went into the error state but never propagated the error. Now, if an error is received while in the flushing state, the error is propagated by calling the decode cb corresponding to the EOS buffer. BUG=647081 TEST=manually verified that AVDA decode errors now propagate to WMPI Committed: https://crrev.com/99d991f6f7c0f480c0a5d8b2165daebe01cd25d5 Cr-Commit-Position: refs/heads/master@{#419001}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/filters/gpu_video_decoder.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
watk
4 years, 3 months ago (2016-09-15 18:56:29 UTC) #5
sandersd (OOO until July 31)
lgtm
4 years, 3 months ago (2016-09-15 19:01:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344703003/20001
4 years, 3 months ago (2016-09-15 19:09:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 22:04:58 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 22:07:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99d991f6f7c0f480c0a5d8b2165daebe01cd25d5
Cr-Commit-Position: refs/heads/master@{#419001}

Powered by Google App Engine
This is Rietveld 408576698