Fix task manager's default sizing.

chrome/browser/ui/views/task_manager_view.cc

Index: chrome/browser/ui/views/task_manager_view.cc
diff --git a/chrome/browser/ui/views/task_manager_view.cc b/chrome/browser/ui/views/task_manager_view.cc
index 513934e7a7322fdd50317b390513253d74da28c5..70bf1c820b29da5cf61c77b9661a0e3a9bbc98be 100644
--- a/chrome/browser/ui/views/task_manager_view.cc
+++ b/chrome/browser/ui/views/task_manager_view.cc
@@ -153,7 +153,15 @@ void TaskManagerView::SetSortDescriptor(const TableSortDescriptor& descriptor) {
 }
 
 gfx::Size TaskManagerView::GetPreferredSize() const {
-  return gfx::Size(460, 270);
+  gfx::Size table_size = tab_table_parent_->GetPreferredSize();
+  // The task name column expands to use excess space but also defaults to

[sky, 2016/09/23 16:22:25]

'to to' -> 'to'

[Evan Stade, 2016/10/04 01:33:13]

Done.

+  // to a very narrow width. Add some extra width here to make the task names
+  // more readable.
+  table_size.set_width(table_size.width() + 180);

[Evan Stade, 2016/09/22 22:42:47]

I also added this because columns that have an expand percent only report a
preferred width that's just enough for the header.[1] In the case of the task
manager, that header is "Task", which means all the tab/process titles longer
than "Task" default to being elided.

[1]
https://cs.chromium.org/chromium/src/ui/views/controls/table/table_utils.cc?r...

[sky, 2016/09/23 16:22:26]

I recommend expanding your comment to include this information as well. That
said, remember that not all locales will have 'Task' as 4 characters. Might this
result in too big a table in some locales?

[Evan Stade, 2016/10/04 01:33:13]

Tried to improve/elaborate comment.
it's possible, but there would be minimal harm. If the rule of thumb is to plan
for translations being up to 3x as long, that won't really amount to that much
space.

+  table_size.set_height(270);
+  gfx::Insets border = GetInsets();
+  table_size.Enlarge(border.width(), border.height());
+  return table_size;
 }
 
 bool TaskManagerView::AcceleratorPressed(const ui::Accelerator& accelerator) {