Fix task manager's default sizing.

chrome/browser/ui/views/task_manager_view.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/task_manager_view.h"
 
 #include <stddef.h>
 
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 135 matching lines @@
   // If |sorted_column_id| is the default value, it means to clear the sort.
   if (descriptor.sorted_column_id != TableSortDescriptor().sorted_column_id) {
     descriptor_list.emplace_back(descriptor.sorted_column_id,
                                  descriptor.is_ascending);
   }
 
   tab_table_->SetSortDescriptors(descriptor_list);
 }
 
 gfx::Size TaskManagerView::GetPreferredSize() const {
-  return gfx::Size(460, 270);
+  gfx::Size table_size = tab_table_parent_->GetPreferredSize();
+  // The task name column expands to use excess space but also defaults to

[sky, 2016/09/23 16:22:25]

'to to' -> 'to'

[Evan Stade, 2016/10/04 01:33:13]

Done.

+  // to a very narrow width. Add some extra width here to make the task names
+  // more readable.
+  table_size.set_width(table_size.width() + 180);

[Evan Stade, 2016/09/22 22:42:47]

I also added this because columns that have an expand percent only report a
preferred width that's just enough for the header.[1] In the case of the task
manager, that header is "Task", which means all the tab/process titles longer
than "Task" default to being elided.

[1]
https://cs.chromium.org/chromium/src/ui/views/controls/table/table_utils.cc?r...

[sky, 2016/09/23 16:22:26]

I recommend expanding your comment to include this information as well. That
said, remember that not all locales will have 'Task' as 4 characters. Might this
result in too big a table in some locales?

[Evan Stade, 2016/10/04 01:33:13]

Tried to improve/elaborate comment.
it's possible, but there would be minimal harm. If the rule of thumb is to plan
for translations being up to 3x as long, that won't really amount to that much
space.

+  table_size.set_height(270);
+  gfx::Insets border = GetInsets();
+  table_size.Enlarge(border.width(), border.height());
+  return table_size;
 }
 
 bool TaskManagerView::AcceleratorPressed(const ui::Accelerator& accelerator) {
   DCHECK_EQ(ui::VKEY_W, accelerator.key_code());
   DCHECK_EQ(ui::EF_CONTROL_DOWN, accelerator.modifiers());
   GetWidget()->Close();
   return true;
 }
 
 bool TaskManagerView::CanResize() const {
@@ skipping 196 matching lines @@
   if (!g_browser_process->local_state())
     return;
 
   const base::DictionaryValue* dictionary =
       g_browser_process->local_state()->GetDictionary(GetWindowName());
   if (dictionary)
     dictionary->GetBoolean("always_on_top", &is_always_on_top_);
 }
 
 }  // namespace task_manager