Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443
Committed: https://crrev.com/8106bcd1f350281fc46095441c1e994b003901e7
Cr-Commit-Position: refs/heads/master@{#418854}

[gab, 2016-09-14 19:54:27]

gab@chromium.org changed reviewers:
+ cbentzel@chromium.org

[gab, 2016-09-14 19:54:28]

Chris PTaL, thanks!

[gab, 2016-09-14 19:57:51]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:59:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:04:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:04:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-09-14 20:30:24]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:30:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 21:10:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:10:39]

Dry run: This issue passed the CQ dry run.

[cbentzel, 2016-09-15 01:27:55]

On 2016/09/14 19:54:28, gab wrote:
> Chris PTaL, thanks!

LGTM as this looks like a fairly straightforward test change. I don't know this
test at all though (or cookie area in general) - adding jww just in case
interested.

Why did the pool strings need to change?

[cbentzel, 2016-09-15 01:28:08]

Description was changed from

==========
Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443
==========

to

==========
Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443
==========

[cbentzel, 2016-09-15 01:28:08]

cbentzel@chromium.org changed reviewers:
+ jww@chromium.org

[gab, 2016-09-15 13:29:58]

On 2016/09/15 01:27:55, cbentzel wrote:
> On 2016/09/14 19:54:28, gab wrote:
> > Chris PTaL, thanks!
> 
> LGTM as this looks like a fairly straightforward test change. I don't know
this
> test at all though (or cookie area in general) - adding jww just in case
> interested.

It's testing code that uses a multi-threaded pool in production, so if anything
this setup is just more likely to be testing lack of thread-affinity properly.

> 
> Why did the pool strings need to change?

I re-labelled the strings after being confused why the pool was reset. Looks
like the initial pool is used to do the SetUp, then at the end of SetUp it's
shutdown (assuming this is to simulate a restart after non-BLOCK_SHUTDOWN tasks
have been dropped or something?). Then the pool is reset into a new pool used by
the test from then on.

[gab, 2016-09-15 13:30:10]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-09-15 13:30:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 13:35:12]

Description was changed from

==========
Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443
==========

to

==========
Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443
==========

[commit-bot: I haz the power, 2016-09-15 13:35:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 13:36:57]

Description was changed from

==========
Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443
==========

to

==========
Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded.

BUG=646443

Committed: https://crrev.com/8106bcd1f350281fc46095441c1e994b003901e7
Cr-Commit-Position: refs/heads/master@{#418854}
==========

[commit-bot: I haz the power, 2016-09-15 13:36:59]

Patchset 2 (id:??) landed as
https://crrev.com/8106bcd1f350281fc46095441c1e994b003901e7
Cr-Commit-Position: refs/heads/master@{#418854}