Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

Issue 2344593003: Make SQLitePersistentCookieStorePerfTest's SequencedWorkerPool multi-threaded. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
diff --git a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc b/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
index 2fbe8dff5ee16dc58b27e11407d00856cf24f2d9..d393ef6584c7def5e04c2f83cdbb6a3776f09363 100644
--- a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
+++ b/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
@@ -33,7 +33,7 @@ const base::FilePath::CharType cookie_filename[] = FILE_PATH_LITERAL("Cookies");
class SQLitePersistentCookieStorePerfTest : public testing::Test {
public:
SQLitePersistentCookieStorePerfTest()
- : pool_owner_(new base::SequencedWorkerPoolOwner(1, "Background Pool")),
+ : pool_owner_(new base::SequencedWorkerPoolOwner(2, "SetupPool")),
loaded_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED),
key_loaded_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
@@ -93,7 +93,7 @@ class SQLitePersistentCookieStorePerfTest : public testing::Test {
// Shut down the pool, causing deferred (no-op) commits to be discarded.
pool_owner_->pool()->Shutdown();
// ~SequencedWorkerPoolOwner blocks on pool shutdown.
- pool_owner_.reset(new base::SequencedWorkerPoolOwner(1, "pool"));
+ pool_owner_.reset(new base::SequencedWorkerPoolOwner(2, "TestPool"));
store_ = new SQLitePersistentCookieStore(
temp_dir_.path().Append(cookie_filename), client_task_runner(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698