Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2344573003: Reland of enable compilation of compiler runtime for iOS simulator. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of enable compilation of compiler runtime for iOS simulator. Was reverted in https://codereview.chromium.org/1893353002/ and the underlying issue has since been fixed. This is required to enable ASan and coverage on simulators (and other tools like UBSan, TSan, ...). BUG=450379, 602649 Committed: https://crrev.com/ca7c2f9c666a565821518072f65ba38c0d51c223 Cr-Commit-Position: refs/heads/master@{#418896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/clang/scripts/package.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 3 months ago (2016-09-15 12:30:42 UTC) #2
Nico
lgtm, fingers crossed :-) Please watch https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot after this lands (I'll watch it too).
4 years, 3 months ago (2016-09-15 16:10:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344573003/1
4 years, 3 months ago (2016-09-15 16:50:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 17:33:36 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:35:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca7c2f9c666a565821518072f65ba38c0d51c223
Cr-Commit-Position: refs/heads/master@{#418896}

Powered by Google App Engine
This is Rietveld 408576698