Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2344523003: Fix SkDrawTextBlobCommand null blob crash (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkDrawTextBlobCommand null blob crash After https://codereview.chromium.org/2335493005, we're moving the param into a local field -> we should no longer access it. TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344523003 Committed: https://skia.googlesource.com/skia/+/02526bd5aafa3503629d993cec6a9b76a106c213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/debugger/SkDrawCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
f(malita)
4 years, 3 months ago (2016-09-14 21:24:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344523003/1
4 years, 3 months ago (2016-09-14 21:24:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/02526bd5aafa3503629d993cec6a9b76a106c213
4 years, 3 months ago (2016-09-14 21:56:01 UTC) #6
robertphillips
4 years, 3 months ago (2016-09-15 12:09:54 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698