Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2335493005: Use sk_sp text blob APIs (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use sk_sp text blob APIs SkTextBlobBuilder::build() -> make() SkAutoTUnref<const SkTextBlob> -> sk_sp<SkTextBlob> drawTextBlob(const SkTextBlob*) -> drawTextBlob(const sk_sp<SkTextBlob>&) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335493005 Committed: https://skia.googlesource.com/skia/+/37283c28aa5bea2204c18956e74f83b238d7a891

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Patch Set 3 : SK_SUPPORT_LEGACY_TEXTBLOB_BUILDER #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -101 lines) Patch
M bench/TextBlobBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/largeglyphblur.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/lcdoverlap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/mixedtextblobs.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/textblob.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/textblobblockreordering.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblobcolortrans.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblobgeometrychange.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/textbloblooper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblobmixedsizes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblobrandomfont.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblobshader.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/textblobtransforms.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblobuseaftergpufree.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/texteffects.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M include/core/SkTextBlob.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M include/utils/SkTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M public.bzl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkTextBlob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 chunk +12 lines, -12 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 5 chunks +7 lines, -6 lines 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/utils/SkTextBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 3 chunks +4 lines, -12 lines 0 comments Download
M tests/TextBlobTest.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
f(malita)
Depends on https://codereview.chromium.org/2335703002/ We may need to leave the old style SkTextBlobBuilder::build() alone for now ...
4 years, 3 months ago (2016-09-12 17:23:11 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2335493005/diff/1/src/gpu/text/GrStencilAndCoverTextContext.cpp File src/gpu/text/GrStencilAndCoverTextContext.cpp (right): https://codereview.chromium.org/2335493005/diff/1/src/gpu/text/GrStencilAndCoverTextContext.cpp#newcode346 src/gpu/text/GrStencilAndCoverTextContext.cpp:346: makeIfNeeded ?
4 years, 3 months ago (2016-09-13 12:38:00 UTC) #8
f(malita)
https://codereview.chromium.org/2335493005/diff/1/src/gpu/text/GrStencilAndCoverTextContext.cpp File src/gpu/text/GrStencilAndCoverTextContext.cpp (right): https://codereview.chromium.org/2335493005/diff/1/src/gpu/text/GrStencilAndCoverTextContext.cpp#newcode346 src/gpu/text/GrStencilAndCoverTextContext.cpp:346: On 2016/09/13 12:37:59, robertphillips wrote: > makeIfNeeded ? Done.
4 years, 3 months ago (2016-09-13 13:41:57 UTC) #9
f(malita)
Chrome & Android are now clear, but I G3 is likely still dependent on the ...
4 years, 3 months ago (2016-09-13 16:32:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335493005/40001
4 years, 3 months ago (2016-09-13 16:32:50 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/13750)
4 years, 3 months ago (2016-09-13 16:34:56 UTC) #19
reed1
lgtm
4 years, 3 months ago (2016-09-13 16:58:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335493005/40001
4 years, 3 months ago (2016-09-13 16:59:26 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:00:26 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/37283c28aa5bea2204c18956e74f83b238d7a891

Powered by Google App Engine
This is Rietveld 408576698