Add MarkupSafe library to third_party (dependency for Jinja2 2.7)

Add MarkupSafe library to third_party (dependency for Jinja2 2.7)

As of version 2.7 Jinja2 depends on the MarkupSafe module.
http://jinja.pocoo.org/docs/intro/#markupsafe-dependency

We are already using Jinja2 v2.6 as a template engine for code generation
in Blink, and we'd like to upgrade it to v2.7.1, for various improvements.
MarkupSafe used to be part of Jinja2, but as of v2.7 has been factored into
a separate module, thus we need to add it separately.

For reference, MarkupSafe (and Jinja2) are also included as third-party libraries in Google App Engine.
https://developers.google.com/appengine/docs/python/tools/libraries27

Blocking:
Issue 23506004: Update Jinja2 (Python template library) to 2.7.1 + add OWNERS
https://codereview.chromium.org/23506004/

Source:
https://pypi.python.org/packages/source/M/MarkupSafe/MarkupSafe-0.18.tar.gz
MD5: f8d252fd05371e51dec2fe9a36890687
SHA-512:
0438ddf0fdab465c40d9afba8c14ad346be0868df654c11130d05e329992d456
a9bc278551970cbd09244a29c77213885d0c363c951b0cfd4d9aa95b248ecff5

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221578

[Nils Barth (inactive), 2013-08-30 05:04:03]

Hiyas,
Adding a new third_party library, which has been factored out of a library we're
already using (jinja2) in an update.

This is just moving code from an existing library (and updating), so should be
of minimal concern, but formally this is a new library.

OWNERS (Carlos, Darin): is this ok?

Open Source Review: includes LICENSE (BSD 3-clause) and checklicenses.py passes
- looks ok?

Security: this isn't shipped (build-only) and is refactoring of existing code,
so should be ok. This module is for handling untrusted user content (HTML etc.),
though we're only using template engine internally for C++ code generation.

Thanks!

[Nils Barth (inactive), 2013-09-05 01:45:04]

ping: review?
(new third_party library, refactored from existing)
* OWNERS (Carlos, Darin): is this ok?
* Open Source Review ?
* Security ?

[Daniel Berlin, 2013-09-05 01:46:03]

Lgtm for open source

Sent from my mobile.  Expect terse, misspelled e-mail
On Aug 29, 2013 10:04 PM, <nbarth@chromium.org> wrote:

> Reviewers: cpu, darin,
open-source-third-party-**reviews_google.com<http://open-source-third-party-reviews_google.com>,
> security_chromium.org,
>
> Message:
> Hiyas,
> Adding a new third_party library, which has been factored out of a library
> we're
> already using (jinja2) in an update.
>
> This is just moving code from an existing library (and updating), so
> should be
> of minimal concern, but formally this is a new library.
>
> OWNERS (Carlos, Darin): is this ok?
>
> Open Source Review: includes LICENSE (BSD 3-clause) and checklicenses.py
> passes
> - looks ok?
>
> Security: this isn't shipped (build-only) and is refactoring of existing
> code,
> so should be ok. This module is for handling untrusted user content (HTML
> etc.),
> though we're only using template engine internally for C++ code generation.
>
> Thanks!
>
> Description:
> Add MarkupSafe library to third_party (dependency for Jinja2 2.7)
>
> As of version 2.7 Jinja2 depends on the MarkupSafe module.
>
http://jinja.pocoo.org/docs/**intro/#markupsafe-dependency<http://jinja.pocoo...
>
> We are already using Jinja2 v2.6 as a template engine for code generation
> in Blink, and we'd like to upgrade it to v2.7.1, for various improvements.
> MarkupSafe used to be part of Jinja2, but as of v2.7 has been factored into
> a separate module, thus we need to add it separately.
>
> For reference, MarkupSafe (and Jinja2) are also included as third-party
> libraries in Google App Engine.
>
https://developers.google.com/**appengine/docs/python/tools/**libraries27<htt...
>
> Issue 23506004: Update Jinja2 (Python template library) to 2.7.1 + add
> OWNERS
>
https://codereview.chromium.**org/23506004/<https://codereview.chromium.org/2...
>
> Please review this at
https://codereview.chromium.**org/23445019/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   A third_party/markupsafe/AUTHORS
>   A third_party/markupsafe/LICENSE
>   A third_party/markupsafe/**MarkupSafe-0.18.tar.gz.md5
>   A third_party/markupsafe/**MarkupSafe-0.18.tar.gz.sha512
>   A + third_party/markupsafe/OWNERS
>   A third_party/markupsafe/README.**chromium
>   A + third_party/markupsafe/__init_**_.py
>   A third_party/markupsafe/_**compat.py
>   A + third_party/markupsafe/_**constants.py
>   A + third_party/markupsafe/_**native.py
>   A third_party/markupsafe/_**speedups.c
>   A third_party/markupsafe/get_**markupsafe.sh
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[darin (slow to review), 2013-09-05 06:16:16]

OK, LGTM

[jschuh, 2013-09-05 13:06:52]

lgtm on security

[cpu_(ooo_6.6-7.5), 2013-09-05 17:19:15]

lgtm

[commit-bot: I haz the power, 2013-09-06 00:50:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/23445019/4001

[commit-bot: I haz the power, 2013-09-06 05:20:03]

Change committed as 221578