Mark exception handlers if they have a stacktrace specified. Do not build a stacktrace if the handl…

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h	(revision 26792)
+++ runtime/vm/raw_object.h	(working copy)
@@ -945,6 +945,7 @@
   struct HandlerInfo {
     intptr_t outer_try_index;  // Try block index of enclosing try block.
     intptr_t handler_pc;       // PC value of handler.
+    bool needs_stacktrace;     // True if a stacktrace is needed.

[hausner, 2013/08/28 16:08:20]

Due to alignment of HandlerInfo elements in the data_ array, this adds 4 bytes
for each exception handler (i.e. catch clause), 8 bytes even in 64bit mode. I
don't know how much that is in total, but we should at least add a TODO here
that we should pack the data more densely. For example, the outer_try_index does
not need to be an intptr_t, I do not think that we'll ever have to deal with
functions that contain 4 billion try statements. That field could be 16 bits,
and the bool can fit it with 8 bits to spare.

[siva, 2013/08/28 17:00:09]

I second this comment.

On 2013/08/28 16:08:20, hausner wrote:

[srdjan, 2013/08/28 20:38:29]

Will do that in a follow up CL.

   };
  private:
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExceptionHandlers);