Mark exception handlers if they have a stacktrace specified. Do not build a stacktrace if the handl…

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 927 matching lines @@
 };
 
 
 class RawExceptionHandlers : public RawObject {
  public:
   // The index into the ExceptionHandlers table corresponds to
   // the try_index of the handler.
   struct HandlerInfo {
     intptr_t outer_try_index;  // Try block index of enclosing try block.
     intptr_t handler_pc;       // PC value of handler.
+    bool needs_stacktrace;     // True if a stacktrace is needed.

[hausner, 2013/08/28 16:08:20]

Due to alignment of HandlerInfo elements in the data_ array, this adds 4 bytes
for each exception handler (i.e. catch clause), 8 bytes even in 64bit mode. I
don't know how much that is in total, but we should at least add a TODO here
that we should pack the data more densely. For example, the outer_try_index does
not need to be an intptr_t, I do not think that we'll ever have to deal with
functions that contain 4 billion try statements. That field could be 16 bits,
and the bool can fit it with 8 bits to spare.

[siva, 2013/08/28 17:00:09]

I second this comment.

On 2013/08/28 16:08:20, hausner wrote:

[srdjan, 2013/08/28 20:38:29]

Will do that in a follow up CL.

   };
  private:
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExceptionHandlers);
 
   // Number of exception handler entries.
   intptr_t length_;
 
   // Array with [length_] entries. Each entry is an array of all handled
   // exception types.
   RawArray* handled_types_data_;
@@ skipping 753 matching lines @@
   // Make sure this is updated when new TypedData types are added.
   ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 12);
   ASSERT(kExternalTypedDataInt8ArrayCid == kTypedDataInt8ArrayViewCid + 13);
   ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 12);
   return (kNullCid - kTypedDataInt8ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_