Rename AnimationPlayerEvent as AnimationPlaybackEvent

Rename AnimationPlayerEvent as AnimationPlaybackEvent

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639
Committed: https://crrev.com/fb139e4ad08c64b1940c5ce4eed21025184d0a1e
Cr-Commit-Position: refs/heads/master@{#419103}

[suzyh_UTC10 (ex-contributor), 2016-09-14 07:30:01]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 07:30:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[suzyh_UTC10 (ex-contributor), 2016-09-14 07:40:08]

Description was changed from

==========
Rename AnimationPlayerEvent as AnimationPlaybackEvent

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

BUG=624639
==========

to

==========
Rename AnimationPlayerEvent as AnimationPlaybackEvent

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639
==========

[suzyh_UTC10 (ex-contributor), 2016-09-14 07:41:02]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 07:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 09:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 09:28:01]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-09-14 21:28:59]

suzyh@chromium.org changed reviewers:
+ foolip@chromium.org, haraken@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-09-14 21:34:29]

haraken: please review bindings/

foolip: please review core/
One thing I'm not entirely sure about is some references to the old name in a
histogram/UseCounter added in
https://chromium.googlesource.com/chromium/src/+/b864804d2c75a5024c4b6d57ee23...
and removed from UseCounter.h by you in
https://chromium.googlesource.com/chromium/src/+/b2343c3b045d6ac978a4e9b003a2...
plus another reference that seems to be related to this, in
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
Is there anything additional I'd need to do here?

[foolip, 2016-09-15 15:49:17]

lgtm

https://codereview.chromium.org/2344473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/AnimationPlaybackEvent.cpp (right):

https://codereview.chromium.org/2344473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/AnimationPlaybackEvent.cpp:21: if
(initializer.hasCurrentTime())
Per spec, but do you know if the only reason that these are nullable on event
interface and dict is so that scripts don't have to provide a value? If the UA
itself can never fire events where either of these are null, I'd suggest
changing the spec to make the dict and its members required and everything
non-nullable. This file would shrink a bit.

[foolip, 2016-09-15 15:51:41]

On 2016/09/14 21:34:29, suzyh wrote:
> haraken: please review bindings/
> 
> foolip: please review core/
> One thing I'm not entirely sure about is some references to the old name in a
> histogram/UseCounter added in
>
https://chromium.googlesource.com/chromium/src/+/b864804d2c75a5024c4b6d57ee23...
> and removed from UseCounter.h by you in
>
https://chromium.googlesource.com/chromium/src/+/b2343c3b045d6ac978a4e9b003a2...

Things in histograms.xml just stay forever, that's fine.

> plus another reference that seems to be related to this, in
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
> Is there anything additional I'd need to do here?

Continuing to test the old name would be odd, so I'd either rename or remove the
line. It doesn't matter really since new events aren't getting this treatment
any more.

[haraken, 2016-09-15 15:59:03]

bindings/ LGTM

[suzyh_UTC10 (ex-contributor), 2016-09-16 00:32:00]

On 2016/09/15 at 15:49:17, foolip wrote:
> lgtm
> 
>
https://codereview.chromium.org/2344473002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/AnimationPlaybackEvent.cpp (right):
> 
>
https://codereview.chromium.org/2344473002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/AnimationPlaybackEvent.cpp:21: if
(initializer.hasCurrentTime())
> Per spec, but do you know if the only reason that these are nullable on event
interface and dict is so that scripts don't have to provide a value? If the UA
itself can never fire events where either of these are null, I'd suggest
changing the spec to make the dict and its members required and everything
non-nullable. This file would shrink a bit.

I checked with Shane and he pointed out that it's possible for currentTime to be
null, and so the point you make does not apply in this case.


On 2016/09/15 at 15:51:41, foolip wrote:
> On 2016/09/14 21:34:29, suzyh wrote:
> > haraken: please review bindings/
> > 
> > foolip: please review core/
> > One thing I'm not entirely sure about is some references to the old name in
a
> > histogram/UseCounter added in
> >
https://chromium.googlesource.com/chromium/src/+/b864804d2c75a5024c4b6d57ee23...
> > and removed from UseCounter.h by you in
> >
https://chromium.googlesource.com/chromium/src/+/b2343c3b045d6ac978a4e9b003a2...
> 
> Things in histograms.xml just stay forever, that's fine.
> 
> > plus another reference that seems to be related to this, in
> >
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
> > Is there anything additional I'd need to do here?
> 
> Continuing to test the old name would be odd, so I'd either rename or remove
the line. It doesn't matter really since new events aren't getting this
treatment any more.

Since this is an imported test, I'll send a PR to WPT directly to remove this
line. Thanks!

[suzyh_UTC10 (ex-contributor), 2016-09-16 00:32:09]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 04:48:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 04:49:48]

Description was changed from

==========
Rename AnimationPlayerEvent as AnimationPlaybackEvent

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639
==========

to

==========
Rename AnimationPlayerEvent as AnimationPlaybackEvent

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639

Committed: https://crrev.com/fb139e4ad08c64b1940c5ce4eed21025184d0a1e
Cr-Commit-Position: refs/heads/master@{#419103}
==========

[commit-bot: I haz the power, 2016-09-16 04:49:49]

Patchset 2 (id:??) landed as
https://crrev.com/fb139e4ad08c64b1940c5ce4eed21025184d0a1e
Cr-Commit-Position: refs/heads/master@{#419103}