Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: reverted unintended change to an __init__ file Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py b/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
index 1393879a473c87de77da3354be3630c2246243e0..20bd66fabc989f88f1dca69fa6fa0a6fb0d764e0 100644
--- a/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
+++ b/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
@@ -4,7 +4,7 @@
import datetime
-from common.git_repository import GitRepository
+from lib.gitiles.gitiles_repository import GitilesRepository
stgao 2016/10/28 18:21:00 order of import
wrengr 2016/10/28 19:24:49 Done.
from common.rietveld import Rietveld
from model import analysis_status as status
from model.wf_culprit import WfCulprit
@@ -38,7 +38,7 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
return 123
return MockedChangeLog()
- self.mock(GitRepository, 'GetChangeLog', Mocked_GetChangeLog)
+ self.mock(GitilesRepository, 'GetChangeLog', Mocked_GetChangeLog)
def _MockBuildEndTime(self):
def Mocked_GetBuildEndTime(*_):
@@ -136,4 +136,4 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
pipeline = SendNotificationForCulpritPipeline()
self.assertFalse(pipeline.run('m', 'b71', 71, 'chromium', 'r7', False))
- self.assertEqual(0, len(rietveld_requests))
+ self.assertEqual(0, len(rietveld_requests))

Powered by Google App Engine
This is Rietveld 408576698