Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: reverted unintended change to an __init__ file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import datetime 5 import datetime
6 6
7 from common.git_repository import GitRepository 7 from lib.gitiles.gitiles_repository import GitilesRepository
stgao 2016/10/28 18:21:00 order of import
wrengr 2016/10/28 19:24:49 Done.
8 from common.rietveld import Rietveld 8 from common.rietveld import Rietveld
9 from model import analysis_status as status 9 from model import analysis_status as status
10 from model.wf_culprit import WfCulprit 10 from model.wf_culprit import WfCulprit
11 from waterfall import build_util 11 from waterfall import build_util
12 from waterfall import send_notification_for_culprit_pipeline 12 from waterfall import send_notification_for_culprit_pipeline
13 from waterfall.send_notification_for_culprit_pipeline import ( 13 from waterfall.send_notification_for_culprit_pipeline import (
14 SendNotificationForCulpritPipeline) 14 SendNotificationForCulpritPipeline)
15 from waterfall.test import wf_testcase 15 from waterfall.test import wf_testcase
16 16
17 17
(...skipping 13 matching lines...) Expand all
31 class MockedChangeLog(object): 31 class MockedChangeLog(object):
32 @property 32 @property
33 def code_review_url(self): 33 def code_review_url(self):
34 return mocked_url 34 return mocked_url
35 35
36 @property 36 @property
37 def commit_position(self): 37 def commit_position(self):
38 return 123 38 return 123
39 39
40 return MockedChangeLog() 40 return MockedChangeLog()
41 self.mock(GitRepository, 'GetChangeLog', Mocked_GetChangeLog) 41 self.mock(GitilesRepository, 'GetChangeLog', Mocked_GetChangeLog)
42 42
43 def _MockBuildEndTime(self): 43 def _MockBuildEndTime(self):
44 def Mocked_GetBuildEndTime(*_): 44 def Mocked_GetBuildEndTime(*_):
45 return _MOCKED_BUILD_END_TIME 45 return _MOCKED_BUILD_END_TIME
46 self.mock(build_util, 'GetBuildEndTime', Mocked_GetBuildEndTime) 46 self.mock(build_util, 'GetBuildEndTime', Mocked_GetBuildEndTime)
47 47
48 def testShouldNotSendNotificationForSingleFailedBuild(self): 48 def testShouldNotSendNotificationForSingleFailedBuild(self):
49 additional_criteria = { 49 additional_criteria = {
50 'within_time_limit': True 50 'within_time_limit': True
51 } 51 }
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 self._MockRietveld(rietveld_requests) 129 self._MockRietveld(rietveld_requests)
130 self._MockGitRepository('url') 130 self._MockGitRepository('url')
131 self.MockUTCNow(_MOCKED_DATETIME_UTCNOW) 131 self.MockUTCNow(_MOCKED_DATETIME_UTCNOW)
132 self._MockBuildEndTime() 132 self._MockBuildEndTime()
133 culprit = WfCulprit.Create('chromium', 'r7', 123) 133 culprit = WfCulprit.Create('chromium', 'r7', 123)
134 culprit.builds.append(['m', 'b71', 71]) 134 culprit.builds.append(['m', 'b71', 71])
135 culprit.put() 135 culprit.put()
136 136
137 pipeline = SendNotificationForCulpritPipeline() 137 pipeline = SendNotificationForCulpritPipeline()
138 self.assertFalse(pipeline.run('m', 'b71', 71, 'chromium', 'r7', False)) 138 self.assertFalse(pipeline.run('m', 'b71', 71, 'chromium', 'r7', False))
139 self.assertEqual(0, len(rietveld_requests)) 139 self.assertEqual(0, len(rietveld_requests))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698