[Findit] Factoring the gitiles (etc) stuff out into its own directory

appengine/findit/lib/gitiles/gitiles_repository.py

Index: appengine/findit/lib/gitiles/gitiles_repository.py
diff --git a/appengine/findit/common/git_repository.py b/appengine/findit/lib/gitiles/gitiles_repository.py
similarity index 95%
rename from appengine/findit/common/git_repository.py
rename to appengine/findit/lib/gitiles/gitiles_repository.py
index 9d49da023fb1b42dfb78e7dc4f2db334005ddb61..9e49add52b10557b900d57e7f793ec3adb29ac2f 100644
--- a/appengine/findit/common/git_repository.py
+++ b/appengine/findit/lib/gitiles/gitiles_repository.py
@@ -8,15 +8,13 @@ from datetime import timedelta
 import json
 import re
 
-from common import diff
-from common.blame import Blame
-from common.blame import Region
-from common.cache_decorator import Cached
-from common.cache_decorator import CompressedMemCacher
-from common.change_log import ChangeLog
-from common.change_log import FileChangeInfo
-from common.repository import Repository
-
+from lib.gitiles import diff
+from lib.gitiles.blame import Blame
+from lib.gitiles.blame import Region
+from lib.gitiles.cache_decorator import Cached, CompressedMemCacher

[stgao, 2016/10/28 18:21:00]

cache_decorator should be in lib/ instead of lib/gitiles/

Other code is using it besides gitiles.

[wrengr, 2016/10/28 19:24:49]

Since when? Last I looked only gitiles_repository.py used it

(In any case, is done.)

+from lib.gitiles.change_log import ChangeLog
+from lib.gitiles.change_log import FileChangeInfo
+from lib.gitiles.git_repository import GitRepository
 
 COMMIT_POSITION_PATTERN = re.compile(
     '^Cr-Commit-Position: refs/heads/master@{#(\d+)}$', re.IGNORECASE)
@@ -28,11 +26,11 @@ TIMEZONE_PATTERN = re.compile('[-+]\d{4}$')
 CACHE_EXPIRE_TIME_SECONDS = 24 * 60 * 60
 
 
-class GitRepository(Repository):
-  """Represents a git repository on https://chromium.googlesource.com."""
+class GitilesRepository(GitRepository):
+  """Use Gitiles to access a repository on https://chromium.googlesource.com."""
 
   def __init__(self, repo_url=None, http_client=None):
-    super(GitRepository, self).__init__()
+    super(GitilesRepository, self).__init__()
     if repo_url and repo_url.endswith('/'):
       self._repo_url = repo_url[:-1]
     else: