[Findit] Factoring the gitiles (etc) stuff out into its own directory

appengine/findit/lib/gitiles/gitiles_repository.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 from datetime import datetime
 from datetime import timedelta
 import json
 import re
 
-from common import diff
-from common.blame import Blame
-from common.blame import Region
-from common.cache_decorator import Cached
-from common.cache_decorator import CompressedMemCacher
-from common.change_log import ChangeLog
-from common.change_log import FileChangeInfo
-from common.repository import Repository
-
+from lib.gitiles import diff
+from lib.gitiles.blame import Blame
+from lib.gitiles.blame import Region
+from lib.gitiles.cache_decorator import Cached, CompressedMemCacher

[stgao, 2016/10/28 18:21:00]

cache_decorator should be in lib/ instead of lib/gitiles/

Other code is using it besides gitiles.

[wrengr, 2016/10/28 19:24:49]

Since when? Last I looked only gitiles_repository.py used it

(In any case, is done.)

+from lib.gitiles.change_log import ChangeLog
+from lib.gitiles.change_log import FileChangeInfo
+from lib.gitiles.git_repository import GitRepository
 
 COMMIT_POSITION_PATTERN = re.compile(
     '^Cr-Commit-Position: refs/heads/master@{#(\d+)}$', re.IGNORECASE)
 CODE_REVIEW_URL_PATTERN = re.compile(
     '^(?:Review URL|Review-Url): (.*\d+).*$', re.IGNORECASE)
 REVERTED_REVISION_PATTERN = re.compile(
     '^> Committed: https://.+/([0-9a-fA-F]{40})$', re.IGNORECASE)
 TIMEZONE_PATTERN = re.compile('[-+]\d{4}$')
 CACHE_EXPIRE_TIME_SECONDS = 24 * 60 * 60
 
 
-class GitRepository(Repository):
-  """Represents a git repository on https://chromium.googlesource.com."""
+class GitilesRepository(GitRepository):
+  """Use Gitiles to access a repository on https://chromium.googlesource.com."""
 
   def __init__(self, repo_url=None, http_client=None):
-    super(GitRepository, self).__init__()
+    super(GitilesRepository, self).__init__()
     if repo_url and repo_url.endswith('/'):
       self._repo_url = repo_url[:-1]
     else:
       self._repo_url = repo_url
 
     self._http_client = http_client
 
   @property
   def repo_url(self):
     return self._repo_url
@@ skipping 236 matching lines @@
 
       for log in data['log']:
         changelogs.append(self._ParseChangeLogFromLogData(log))
 
       if 'next' in data:
         next_end_revision = data['next']
       else:
         next_end_revision = None
 
     return changelogs