Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 23444019: Do not CrossFade the bounds change of AdjustWindowBoundsForWorkAreaChange() (Closed)

Created:
7 years, 3 months ago by Jun Mukai
Modified:
7 years, 3 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Do not CrossFade the bounds change of AdjustWindowBoundsForWorkAreaChange() This causes tricky reordering of OnDeviceScaleFactorChanged() for the transition from mirroring to extended with 1x display and 2x display. BUG=267698 R=oshima@chromium.org, sky@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220426

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M ash/wm/workspace/workspace_layout_manager.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
7 years, 3 months ago (2013-08-29 18:38:52 UTC) #1
oshima
lgtm https://codereview.chromium.org/23444019/diff/1/ash/wm/workspace/workspace_layout_manager.cc File ash/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/23444019/diff/1/ash/wm/workspace/workspace_layout_manager.cc#newcode217 ash/wm/workspace/workspace_layout_manager.cc:217: // the transition between mirroring and extended. See ...
7 years, 3 months ago (2013-08-29 18:56:48 UTC) #2
Jun Mukai
https://codereview.chromium.org/23444019/diff/1/ash/wm/workspace/workspace_layout_manager.cc File ash/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/23444019/diff/1/ash/wm/workspace/workspace_layout_manager.cc#newcode217 ash/wm/workspace/workspace_layout_manager.cc:217: // the transition between mirroring and extended. See also: ...
7 years, 3 months ago (2013-08-29 19:48:13 UTC) #3
Jun Mukai
sky, please take a look.
7 years, 3 months ago (2013-08-29 19:49:10 UTC) #4
sky
LGTM
7 years, 3 months ago (2013-08-29 20:18:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/23444019/5001
7 years, 3 months ago (2013-08-29 20:21:05 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 23:26:00 UTC) #7
Message was sent while issue was closed.
Change committed as 220426

Powered by Google App Engine
This is Rietveld 408576698