Do not CrossFade the bounds change of AdjustWindowBoundsForWorkAreaChange()

ash/wm/workspace/workspace_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_layout_manager.h"
 
 #include "ash/display/display_controller.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_ash.h"
 #include "ash/shelf/shelf_layout_manager.h"
@@ skipping 195 matching lines @@
   work_area_ = ScreenAsh::GetDisplayWorkAreaBoundsInParent(window_->parent());
   BaseLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange(reason);
 }
 
 void WorkspaceLayoutManager::AdjustWindowBoundsForWorkAreaChange(
     Window* window,
     AdjustWindowReason reason) {
   if (!GetTrackedByWorkspace(window))
     return;
 
-  // Use cross fade transition for the maximized window if the adjustment
-  // happens due to the shelf's visibility change. Otherwise the background
-  // can be seen slightly between the bottom edge of resized-window and
-  // the animating shelf.
-  // TODO(mukai): this cause slight blur at the window frame because of the
-  // cross fade. I think this is better, but should reconsider if someone
-  // raises voice for this.
+  // Do not cross fade here: the window's layer hierarchy may be messed up for
+  // the transition between mirroring and extended. See also: crbug.com/267698

[oshima, 2013/08/29 18:56:48]

can you add

TODO(oshima): Differentiate display change and shelf visibility change, and
bring back CrossFade animation.

[Jun Mukai, 2013/08/29 19:48:14]

Done.

   if (wm::IsWindowMaximized(window) &&
       reason == ADJUST_WINDOW_WORK_AREA_INSETS_CHANGED) {
-    CrossFadeToBounds(window, ScreenAsh::GetMaximizedWindowBoundsInParent(
+    SetChildBoundsDirect(window, ScreenAsh::GetMaximizedWindowBoundsInParent(
         window->parent()->parent()));
     return;
   }
 
   if (SetMaximizedOrFullscreenBounds(window))
     return;
 
   gfx::Rect bounds = window->bounds();
   switch (reason) {
     case ADJUST_WINDOW_DISPLAY_SIZE_CHANGED:
@@ skipping 124 matching lines @@
     SetChildBoundsDirect(
         window,
         ScreenAsh::GetDisplayBoundsInParent(window->parent()->parent()));
     return true;
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace ash