Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2344273003: Fix crash in BlitFramebufferCHROMIUM with a null read buffer. (Closed)

Created:
4 years, 3 months ago by piman
Modified:
4 years, 3 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in BlitFramebufferCHROMIUM with a null read buffer. BUG=646814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/2b52c8624a013e7449e399527a8ee6ddce6aa7f8 Cr-Commit-Position: refs/heads/master@{#419351}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
piman
I missed this one case in https://codereview.chromium.org/2347063002
4 years, 3 months ago (2016-09-16 23:12:44 UTC) #5
vmiura
lgtm
4 years, 3 months ago (2016-09-16 23:23:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344273003/20001
4 years, 3 months ago (2016-09-16 23:29:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-17 00:49:30 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:50:55 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b52c8624a013e7449e399527a8ee6ddce6aa7f8
Cr-Commit-Position: refs/heads/master@{#419351}

Powered by Google App Engine
This is Rietveld 408576698