gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 2344273003: Fix crash in BlitFramebufferCHROMIUM with a null read buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2344273003: Fix crash in BlitFramebufferCHROMIUM with a null read buffer. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index b9a3ac0af21f91f9abd65bca6ece5c285a5ee357..c81a5d05ff4edd72dc5139d2afdca906f4fa3357 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -7643,7 +7643,7 @@ void GLES2DecoderImpl::DoBlitFramebufferCHROMIUM(

DCHECK(draw_framebuffer);

const Framebuffer::Attachment* draw_buffer =

draw_framebuffer->GetAttachment(attachment);

- if (!draw_buffer) {

+ if (!draw_buffer || !read_buffer) {

continue;

}

if (draw_buffer->IsSameAttachment(read_buffer)) {

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc » ('j') | no next file with comments »