Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2344243002:
Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (Closed)
DescriptionAdd work-around to symlink.gni to avoid "not up-to-date" ninja errors
Ninja bug: https://github.com/ninja-build/ninja/issues/1186
BUG=646165
Committed: https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa
Cr-Commit-Position: refs/heads/master@{#419751}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 19 (10 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/16 18:11:25, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run Note: I'm not positive that this work-around actually works. I'm now having a really hard time repro'ing the bug locally. Yesterday I had a nice reliable trick to make it happen, but it's not working anymore today. It seems it's also somewhat of a race condition with the order in which ninja builds things. The bots also show that sometimes everything is up-to-date and sometimes not.
Description was changed from ========== Add work-around to symlink.gni to avoid "not up-to-date" ninja errors Ninja bug: https://github.com/ninja-build/ninja/issues/1186 BUG=646165 ========== to ========== Add work-around to symlink.gni to avoid "not up-to-date" ninja errors Ninja bug: https://github.com/ninja-build/ninja/issues/1186 BUG=646165 ==========
agrieve@chromium.org changed reviewers: + dpranke@chromium.org
On 2016/09/16 18:12:46, agrieve wrote: > On 2016/09/16 18:11:25, agrieve wrote: > > The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run > > Note: I'm not positive that this work-around actually works. I'm now having a > really hard time repro'ing the bug locally. Yesterday I had a nice reliable > trick to make it happen, but it's not working anymore today. It seems it's also > somewhat of a race condition with the order in which ninja builds things. The > bots also show that sometimes everything is up-to-date and sometimes not. thus - I'm planning on testing this just by seeing if the bots stop reporting not up-to-date consistently.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/16 18:21:16, agrieve wrote: > On 2016/09/16 18:12:46, agrieve wrote: > > On 2016/09/16 18:11:25, agrieve wrote: > > > The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run > > > > Note: I'm not positive that this work-around actually works. I'm now having a > > really hard time repro'ing the bug locally. Yesterday I had a nice reliable > > trick to make it happen, but it's not working anymore today. It seems it's > also > > somewhat of a race condition with the order in which ninja builds things. The > > bots also show that sometimes everything is up-to-date and sometimes not. > > thus - I'm planning on testing this just by seeing if the bots stop reporting > not up-to-date consistently. bump
lgtm. (Sorry, thought I had already reviewed this).
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add work-around to symlink.gni to avoid "not up-to-date" ninja errors Ninja bug: https://github.com/ninja-build/ninja/issues/1186 BUG=646165 ========== to ========== Add work-around to symlink.gni to avoid "not up-to-date" ninja errors Ninja bug: https://github.com/ninja-build/ninja/issues/1186 BUG=646165 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add work-around to symlink.gni to avoid "not up-to-date" ninja errors Ninja bug: https://github.com/ninja-build/ninja/issues/1186 BUG=646165 ========== to ========== Add work-around to symlink.gni to avoid "not up-to-date" ninja errors Ninja bug: https://github.com/ninja-build/ninja/issues/1186 BUG=646165 Committed: https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa Cr-Commit-Position: refs/heads/master@{#419751} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa Cr-Commit-Position: refs/heads/master@{#419751}
Message was sent while issue was closed.
jyquinn@chromium.org changed reviewers: + jyquinn@chromium.org
Message was sent while issue was closed.
This CL is breaking iOS build. cc sdefresne@ as our resident symlink expert. https://codereview.chromium.org/2344243002/diff/1/build/symlink.py File build/symlink.py (right): https://codereview.chromium.org/2344243002/diff/1/build/symlink.py#newcode56 build/symlink.py:56: os.utime(s, None) Should this be os.utime(t, None) rather than s? This CL is causing compilation failure on iOS.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2356973002/ by jyquinn@chromium.org. The reason for reverting is: Breaks iOS build with failure: FAILED: gen/linked_src/third_party/objective_c/google_toolbox_for_mac python ../../build/symlink.py --update-target-mtimes -f ../../../../../../third_party/google_toolbox_for_mac/src gen/linked_src/third_party/objective_c/google_toolbox_for_mac Traceback (most recent call last): File "../../build/symlink.py", line 65, in <module> sys.exit(Main(sys.argv)) File "../../build/symlink.py", line 56, in Main os.utime(s, None) OSError: [Errno 2] No such file or directory: '../../../../../../third_party/google_toolbox_for_mac/src'. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
