 Chromium Code Reviews
 Chromium Code Reviews Issue 2344243002:
  Add work-around to symlink.gni to avoid "not up-to-date" ninja errors  (Closed)
    
  
    Issue 2344243002:
  Add work-around to symlink.gni to avoid "not up-to-date" ninja errors  (Closed) 
  | Index: build/symlink.py | 
| diff --git a/build/symlink.py b/build/symlink.py | 
| index 5a261dcad93e1bddc77b42312f552a12dc8c131f..564c0777bd575cd0019e2efcb0dd359f09cb24d0 100755 | 
| --- a/build/symlink.py | 
| +++ b/build/symlink.py | 
| @@ -24,6 +24,7 @@ def Main(argv): | 
| parser = optparse.OptionParser() | 
| parser.add_option('-f', '--force', action='store_true') | 
| parser.add_option('--touch') | 
| + parser.add_option('--update-target-mtimes', action='store_true') | 
| options, args = parser.parse_args(argv[1:]) | 
| if len(args) < 2: | 
| @@ -49,6 +50,10 @@ def Main(argv): | 
| os.symlink(s, t) | 
| else: | 
| raise | 
| + if options.update_target_mtimes: | 
| + # Work-around for ninja bug: | 
| + # https://github.com/ninja-build/ninja/issues/1186 | 
| + os.utime(s, None) | 
| 
Jackie Quinn
2016/09/20 22:09:52
Should this be os.utime(t, None) rather than s? Th
 | 
| if options.touch: |