Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
234423007:
Minor cleanup to RenderLayerScrollableArea::setNeedsCompositedScrolling. (Closed)
|
Created:
6 years, 8 months ago by ojan Modified:
6 years, 8 months ago CC:
bemjb+rendering_chromium.org, blink-layers+watch_chromium.org, blink-reviews, dsinclair, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1 Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionMinor cleanup to RenderLayerScrollableArea::setNeedsCompositedScrolling.
There's no reason for this function to return a bool. One caller
cares about it and the other doesn't. It's should be
the caller's job to track whether the bool changed.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171371
Patch Set 1 #Patch Set 2 : fix windows compile error #
Messages
Total messages: 24 (0 generated)
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/234423007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_rel
The CQ bit was checked by ojan@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/234423007/1
The CQ bit was unchecked by esprehn@chromium.org
The compile failures were actually you: FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\WebKit\Source\core\rendering\webcore_rendering.RenderLayerScrollableArea.obj.rsp /c ..\..\third_party\WebKit\Source\core\rendering\RenderLayerScrollableArea.cpp /Foobj\third_party\WebKit\Source\core\rendering\webcore_rendering.RenderLayerScrollableArea.obj /Fdobj\third_party\WebKit\Source\core\webcore_rendering.cc.pdb e:\b\build\slave\win_layout\build\src\third_party\webkit\source\core\rendering\renderlayerscrollablearea.cpp(1457) :error C4389: '!=' : signed/unsigned mismatch ninja: build stopped: subcommand failed.
The CQ bit was checked by ojan@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/234423007/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by ojan@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/234423007/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_rel
The CQ bit was checked by ojan@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/234423007/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/234423007/40001
Message was sent while issue was closed.
Change committed as 171371 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
