Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 234423007: Minor cleanup to RenderLayerScrollableArea::setNeedsCompositedScrolling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix windows compile error Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerScrollableArea.cpp
diff --git a/Source/core/rendering/RenderLayerScrollableArea.cpp b/Source/core/rendering/RenderLayerScrollableArea.cpp
index 591abf0e3a4161669ef8099d60cfe71f1d77f50e..826344e6d52992794f1026937917626fe888192f 100644
--- a/Source/core/rendering/RenderLayerScrollableArea.cpp
+++ b/Source/core/rendering/RenderLayerScrollableArea.cpp
@@ -1454,8 +1454,8 @@ void RenderLayerScrollableArea::updateNeedsCompositedScrolling()
needsCompositedScrolling |= needsToBeStackingContainer;
}
- const bool needsCompositedScrollingDidChange = setNeedsCompositedScrolling(needsCompositedScrolling);
- if (needsToBeStackingContainerDidChange || needsCompositedScrollingDidChange) {
+ if (needsToBeStackingContainerDidChange || this->needsCompositedScrolling() != needsCompositedScrolling) {
+ setNeedsCompositedScrolling(needsCompositedScrolling);
// Note, the z-order lists may need to be rebuilt, but our code guarantees
// that we have not affected stacking, so we will not dirty
// m_descendantsAreContiguousInStackingOrder for either us or our stacking
@@ -1464,15 +1464,6 @@ void RenderLayerScrollableArea::updateNeedsCompositedScrolling()
}
}
-bool RenderLayerScrollableArea::setNeedsCompositedScrolling(bool needsCompositedScrolling)
-{
- if (this->needsCompositedScrolling() == needsCompositedScrolling)
- return false;
-
- m_needsCompositedScrolling = needsCompositedScrolling;
- return true;
-}
-
void RenderLayerScrollableArea::updateCompositingLayersAfterScroll()
{
RenderLayerCompositor* compositor = m_box->view()->compositor();
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698