Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2344193003: [layoutng] Remove TODO comment about DeviceWidth/DeviceHeight (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Remove TODO comment about DeviceWidth/DeviceHeight I have verified that vh/vw are resolved by the style system before these units reach layout, so we don't need to worry about DeviceWidth/DeviceHeight here. R=mstensho@opera.com,eae@chromium.org,ikilpatrick@chromium.org BUG=635619 Committed: https://crrev.com/94e8b628668646bf578d3f350e7d6d5ca0453e54 Cr-Commit-Position: refs/heads/master@{#419366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
cbiesinger
4 years, 3 months ago (2016-09-16 21:37:13 UTC) #1
ikilpatrick
lgtm
4 years, 3 months ago (2016-09-16 23:50:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344193003/1
4 years, 3 months ago (2016-09-17 03:01:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 03:06:08 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 03:07:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94e8b628668646bf578d3f350e7d6d5ca0453e54
Cr-Commit-Position: refs/heads/master@{#419366}

Powered by Google App Engine
This is Rietveld 408576698