Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

Issue 2344193003: [layoutng] Remove TODO comment about DeviceWidth/DeviceHeight (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
index 8e2fa7f696353fe741dce04d11995ed2dd6852eb..d6fdcb327c60ef5c58fbe0462a04531afd3ad099 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
@@ -55,12 +55,8 @@ LayoutUnit resolveInlineLength(const NGConstraintSpace& constraintSpace,
return LayoutUnit();
case DeviceWidth:
case DeviceHeight:
- // TODO(layout-ng): Do we need to handle this here or does the style
- // system already compute these?
- return LayoutUnit();
case ExtendToZoom:
- NOTREACHED()
- << "ExtendToZoom should only be used for viewport definitions";
+ NOTREACHED() << "These should only be used for viewport definitions";
case MaxSizeNone:
default:
NOTREACHED();
@@ -111,12 +107,8 @@ LayoutUnit resolveBlockLength(const NGConstraintSpace& constraintSpace,
return contentSize;
case DeviceWidth:
case DeviceHeight:
- // TODO(layout-ng): Do we need to handle this here or does the style
- // system already compute these?
- return LayoutUnit();
case ExtendToZoom:
- NOTREACHED()
- << "ExtendToZoom should only be used for viewport definitions";
+ NOTREACHED() << "These should only be used for viewport definitions";
case MaxSizeNone:
default:
NOTREACHED();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698