tools/testing/dart/test_runner.dart - Issue 23441045: Consider tests as flaky if it contains more than one marker (which can occur when running the test)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 23441045: Consider tests as flaky if it contains more than one marker (which can occur when running the test) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index 8058f04b9579a3e36d6309e8d87752fae48d8c59..658a1c4b7aec04420563bf4103777ffe5ea0b380 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -547,9 +547,9 @@ class TestCase extends UniqueObject {

}

var flags = new Set.from(expectedOutcomes);

- flags..remove(TIMEOUT)

+ flags..remove(OK)

..remove(SLOW);

- return flags.contains(PASS) && flags.length > 1;

+ return flags.length > 1;

}

bool get isFinished {

« no previous file with comments | « no previous file | no next file » | no next file with comments »