Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 23441045: Consider tests as flaky if it contains more than one marker (which can occur when running the test) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 540
541 bool get usesWebDriver => TestUtils.usesWebDriver(configuration['runtime']); 541 bool get usesWebDriver => TestUtils.usesWebDriver(configuration['runtime']);
542 542
543 bool get isFlaky { 543 bool get isFlaky {
544 if (expectedOutcomes.contains(SKIP) || 544 if (expectedOutcomes.contains(SKIP) ||
545 expectedOutcomes.contains(SKIP_BY_DESIGN)) { 545 expectedOutcomes.contains(SKIP_BY_DESIGN)) {
546 return false; 546 return false;
547 } 547 }
548 548
549 var flags = new Set.from(expectedOutcomes); 549 var flags = new Set.from(expectedOutcomes);
550 flags..remove(TIMEOUT) 550 flags..remove(OK)
551 ..remove(SLOW); 551 ..remove(SLOW);
552 return flags.contains(PASS) && flags.length > 1; 552 return flags.length > 1;
553 } 553 }
554 554
555 bool get isFinished { 555 bool get isFinished {
556 return !lastCommandOutput.successful || 556 return !lastCommandOutput.successful ||
557 commands.length == commandOutputs.length; 557 commands.length == commandOutputs.length;
558 } 558 }
559 } 559 }
560 560
561 561
562 /** 562 /**
(...skipping 1593 matching lines...) Expand 10 before | Expand all | Expand 10 after
2156 } 2156 }
2157 } 2157 }
2158 2158
2159 void eventAllTestsDone() { 2159 void eventAllTestsDone() {
2160 for (var listener in _eventListener) { 2160 for (var listener in _eventListener) {
2161 listener.allDone(); 2161 listener.allDone();
2162 } 2162 }
2163 _allDone(); 2163 _allDone();
2164 } 2164 }
2165 } 2165 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698