Move global V8::UseCrankshaft() into the Isolate.

Move global V8::UseCrankshaft() into the Isolate.

R=jkummerow@chromium.org
BUG=v8:2744
Committed: http://code.google.com/p/v8/source/detail?r=16494

[Sven Panne, 2013-09-03 06:35:05]

DBC nit

https://codereview.chromium.org/23441029/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/23441029/diff/1/src/isolate.h#newcode1062
src/isolate.h:1062: bool use_crankshaft() { return use_crankshaft_; }
Nit: const

[Michael Starzinger, 2013-09-03 07:30:57]

https://codereview.chromium.org/23441029/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/23441029/diff/1/src/isolate.h#newcode1062
src/isolate.h:1062: bool use_crankshaft() { return use_crankshaft_; }
On 2013/09/03 06:35:05, Sven Panne wrote:
> Nit: const

Done.

[Jakob Kummerow, 2013-09-03 08:35:13]

LGTM.

I think at some point the cctests framework should provide a way to access the
current isolate without relying on Isolate::Current(), but that's clearly a plan
for another day.

[Sven Panne, 2013-09-03 08:38:13]

On 2013/09/03 08:35:13, Jakob wrote:
> LGTM.
> 
> I think at some point the cctests framework should provide a way to access the
> current isolate without relying on Isolate::Current(), but that's clearly a
plan
> for another day.

We have that already: You can get it from the LocalEnv and/or the CcTest.

[Michael Starzinger, 2013-09-03 08:38:25]

I couldn't agree more with your statement that the CcTest class should provide a
way to do that. Unfortunately we still have three different ways V8 is
initialized in cctests (CcTest::InitializeVM, LocalContext or some random call
into the API). So yeah, another day. :/

[Michael Starzinger, 2013-09-03 08:50:14]

Committed patchset #2 manually as r16494 (presubmit successful).