Don't check the result of new for NULL.

Don't check the result of new for NULL.

new throws on allocation error. We build with exceptions disabled, but we use
an allocator that crashes the process when memory allocation fails, so this
check isn't necessary.

Fixes some issues reported by PVS-Studio: http://www.viva64.com/en/b/0205/

BUG=271530
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229058

[Nico, 2013-08-31 03:37:02]

thestig: chrome/
akalin: net/
yzshen: ppapi/

[yzshen1, 2013-09-01 07:43:14]

ppapi LGTM

[Lei Zhang, 2013-09-02 20:09:34]

For the code in a tools directory, does the assumption that the allocator
crashes the program on OOM hold? I don't see
base::EnableTerminationOnOutOfMemory() getting called in these cases.

[rvargas (doing something else), 2013-09-03 19:01:05]

https://codereview.chromium.org/23441026/diff/1/net/tools/crash_cache/crash_c...
File net/tools/crash_cache/crash_cache.cc (right):

https://codereview.chromium.org/23441026/diff/1/net/tools/crash_cache/crash_c...
net/tools/crash_cache/crash_cache.cc:271: if (!cache->SetMaxSize(0x100000))
Can we leave this as it was? This is a tool, not part of the released product
(so the allocator doesn't necessarily crash when returning null), and the
purpose of the tool is to crash the cache at specific points, so crashing here
instead of returning an error is arguably the wrong behavior.

[Nico, 2013-09-03 19:17:32]

https://codereview.chromium.org/23441026/diff/1/net/tools/crash_cache/crash_c...
File net/tools/crash_cache/crash_cache.cc (right):

https://codereview.chromium.org/23441026/diff/1/net/tools/crash_cache/crash_c...
net/tools/crash_cache/crash_cache.cc:271: if (!cache->SetMaxSize(0x100000))
On 2013/09/03 19:01:06, rvargas wrote:
> Can we leave this as it was? This is a tool, not part of the released product
> (so the allocator doesn't necessarily crash when returning null), and the
> purpose of the tool is to crash the cache at specific points, so crashing here
> instead of returning an error is arguably the wrong behavior.

Have you checked that new actually returns null on error? According to the C++
standard it doesn't, and at least with libstdc++ new throws in -fno-exception
builds too as far as I know.

[akalin, 2013-10-07 23:28:07]

removing myself from reviewers, as looks like rvargas is handling it

[rvargas (doing something else), 2013-10-16 19:01:23]

lgtm

https://codereview.chromium.org/23441026/diff/1/net/tools/crash_cache/crash_c...
File net/tools/crash_cache/crash_cache.cc (right):

https://codereview.chromium.org/23441026/diff/1/net/tools/crash_cache/crash_c...
net/tools/crash_cache/crash_cache.cc:271: if (!cache->SetMaxSize(0x100000))
On 2013/09/03 19:17:33, Nico wrote:
> On 2013/09/03 19:01:06, rvargas wrote:
> > Can we leave this as it was? This is a tool, not part of the released
product
> > (so the allocator doesn't necessarily crash when returning null), and the
> > purpose of the tool is to crash the cache at specific points, so crashing
here
> > instead of returning an error is arguably the wrong behavior.
> 
> Have you checked that new actually returns null on error? According to the C++
> standard it doesn't, and at least with libstdc++ new throws in -fno-exception
> builds too as far as I know.

As of vs2010 this also crashes with C++ exceptions disabled. So, nevermind.

[commit-bot: I haz the power, 2013-10-16 19:04:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/23441026/1

[Lei Zhang, 2013-10-16 20:27:24]

lgtm

[commit-bot: I haz the power, 2013-10-16 20:36:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/23441026/1

[commit-bot: I haz the power, 2013-10-16 21:20:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/23441026/1

[commit-bot: I haz the power, 2013-10-17 00:09:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/23441026/1

[commit-bot: I haz the power, 2013-10-17 01:26:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/23441026/1

[commit-bot: I haz the power, 2013-10-17 03:56:33]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-10-17 04:12:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/23441026/1

[commit-bot: I haz the power, 2013-10-17 05:50:36]

Change committed as 229058