Don't check the result of new for NULL.

net/tools/crash_cache/crash_cache.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This command-line program generates the set of files needed for the crash-
 // cache unit tests (DiskCacheTest,CacheBackend_Recover*). This program only
 // works properly on debug mode, because the crash functionality is not compiled
 // on release builds of the cache.
 
 #include <string>
@@ skipping 250 matching lines @@
 }
 
 // Generates the files for insertion and removals on heavy loaded caches.
 int LoadOperations(const base::FilePath& path, RankCrashes action,
                    base::Thread* cache_thread) {
   DCHECK(action >= disk_cache::INSERT_LOAD_1);
 
   // Work with a tiny index table (16 entries).
   disk_cache::BackendImpl* cache = new disk_cache::BackendImpl(
       path, 0xf, cache_thread->message_loop_proxy().get(), NULL);
-  if (!cache || !cache->SetMaxSize(0x100000))
+  if (!cache->SetMaxSize(0x100000))

[rvargas (doing something else), 2013/09/03 19:01:06]

Can we leave this as it was? This is a tool, not part of the released product
(so the allocator doesn't necessarily crash when returning null), and the
purpose of the tool is to crash the cache at specific points, so crashing here
instead of returning an error is arguably the wrong behavior.

[Nico, 2013/09/03 19:17:33]

Have you checked that new actually returns null on error? According to the C++
standard it doesn't, and at least with libstdc++ new throws in -fno-exception
builds too as far as I know.

[rvargas (doing something else), 2013/10/16 19:01:23]

As of vs2010 this also crashes with C++ exceptions disabled. So, nevermind.

     return GENERIC;
 
   // No experiments and use a simple LRU.
   cache->SetFlags(disk_cache::kNoRandom);
   net::TestCompletionCallback cb;
   int rv = cache->Init(cb.callback());
   if (cb.GetResult(rv) != net::OK || cache->GetEntryCount())
     return GENERIC;
 
   int seed = static_cast<int>(Time::Now().ToInternalValue());
@@ skipping 91 matching lines @@
 
   base::FilePath path;
   PathService::Get(base::DIR_SOURCE_ROOT, &path);
   path = path.AppendASCII("net");
   path = path.AppendASCII("data");
   path = path.AppendASCII("cache_tests");
   path = path.AppendASCII("new_crashes");
 
   return SlaveCode(path, action);
 }