sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 23440034: Make sure we throw the right NSM error when indexing out of range of a variable that can be null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 23440034: Make sure we throw the right NSM error when indexing out of range of a variable that can be null. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 27429)

+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)

@@ -877,7 +877,7 @@

length.instructionType = HType.INTEGER;

indexNode.block.addBefore(indexNode, length);

- HBoundsCheck check = new HBoundsCheck(indexArgument, length);

+ HBoundsCheck check = new HBoundsCheck(indexArgument, length, array);

indexNode.block.addBefore(indexNode, check);

// If the index input to the bounds check was not known to be an integer

// then we replace its uses with the bounds check, which is known to be an

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('k') | sdk/lib/_internal/lib/js_helper.dart » ('j') | no next file with comments »