Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2343913003: Implement Harmony spec for dialog/bubble borders. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Harmony spec for dialog/bubble border aesthetics. Uses drawing commands rather than raster assets. This CL tries to retain/reuse the same positioning logic that already exists, but I didn't attempt to correct any bugs in positioning that might be introduced. That's up next. BUG=635170 Committed: https://crrev.com/0bd5f0cb97cd94f0bf6552f8f22d40c22d975b5f Cr-Commit-Position: refs/heads/master@{#419203}

Patch Set 1 #

Patch Set 2 : just these changes #

Patch Set 3 : better comments #

Patch Set 4 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -5 lines) Patch
M ui/views/bubble/bubble_border.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 2 3 12 chunks +86 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Evan Stade
4 years, 3 months ago (2016-09-15 20:27:51 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-15 22:48:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343913003/40001
4 years, 3 months ago (2016-09-16 01:21:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/264086) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-16 01:29:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343913003/60001
4 years, 3 months ago (2016-09-16 16:43:43 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-16 17:35:55 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:37:51 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0bd5f0cb97cd94f0bf6552f8f22d40c22d975b5f
Cr-Commit-Position: refs/heads/master@{#419203}

Powered by Google App Engine
This is Rietveld 408576698