Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2343913002: Fix closure compile (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-ntp_chromium.org, pedrosimonetti+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compile TBR=dpapad@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a03615942fb43dd1d90af02ef3b45b95da2f7f2a Cr-Commit-Position: refs/heads/master@{#418941}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 1 chunk +2 lines, -2 lines 1 comment Download

Depends on Patchset:

Issue 2340203002 Patch 1

Messages

Total messages: 8 (3 generated)
Dan Beam
4 years, 3 months ago (2016-09-15 17:37:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343913002/1
4 years, 3 months ago (2016-09-15 17:38:26 UTC) #4
dpapad
LGTM https://codereview.chromium.org/2343913002/diff/1/chrome/browser/resources/ntp4/apps_page.js File chrome/browser/resources/ntp4/apps_page.js (right): https://codereview.chromium.org/2343913002/diff/1/chrome/browser/resources/ntp4/apps_page.js#newcode393 chrome/browser/resources/ntp4/apps_page.js:393: * @param {Event} e The click/auxclick event. Should ...
4 years, 3 months ago (2016-09-15 17:39:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 20:01:06 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:05:22 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a03615942fb43dd1d90af02ef3b45b95da2f7f2a
Cr-Commit-Position: refs/heads/master@{#418941}

Powered by Google App Engine
This is Rietveld 408576698