Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2340203002: chrome://apps - don't launch apps on right click. Only left or middle. (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
Navid Zolghadr
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome://apps - don't launch apps on right click. Only left or middle. R=nzolghadr@chromium.org BUG=647095 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/40aece67bda1a31539b152d4e092b1c712417b38 Cr-Commit-Position: refs/heads/master@{#418880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/ntp4/apps_page.js View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Dan Beam
4 years, 3 months ago (2016-09-15 01:37:36 UTC) #2
Navid Zolghadr
lgtm. Thanks for fixing this.
4 years, 3 months ago (2016-09-15 14:23:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340203002/1
4 years, 3 months ago (2016-09-15 16:07:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 16:14:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:10:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40aece67bda1a31539b152d4e092b1c712417b38
Cr-Commit-Position: refs/heads/master@{#418880}

Powered by Google App Engine
This is Rietveld 408576698