CSS Calc: Use Lengths instead of numbers to represent pixels

CSS Calc: Use Lengths instead of numbers to represent pixels

Platform CalcExpressionNumber is overloaded with two uses semantic
meanings: numbers and pixel lengths. This makes conversion from platform
calcs to CSS calcs impossible to do accurately.

BUG=260097
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158790

[Srini, 2013-09-16 11:01:04]

On 2013/09/16 08:01:25, alancutter wrote:

Thanks alancutter for catching it. I will redo my test once your patch gets in.

[Mike Lawther (Google), 2013-09-16 13:53:37]

lgtm

[ojan, 2013-10-02 23:36:33]

lgtm

Is there any way to also write a layout test for this? Whenever the behavior is
exposed to the web, layout tests are still the preferred way to verify the
behavior. Layout tests keep working even as you change the code out from under
it.

To be clear, the unittests are fine to do in addition.

[alancutter (OOO until 2018), 2013-10-02 23:41:33]

On 2013/10/02 23:36:33, ojan wrote:
> lgtm
> 
> Is there any way to also write a layout test for this? Whenever the behavior
is
> exposed to the web, layout tests are still the preferred way to verify the
> behavior. Layout tests keep working even as you change the code out from under
> it.
> 
> To be clear, the unittests are fine to do in addition.

This is not exposed to the web yet but it soon will be once the platform calc ->
CSS calc conversion functionality becomes available for others to use.

[commit-bot: I haz the power, 2013-10-02 23:41:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/23439004/9001

[commit-bot: I haz the power, 2013-10-03 00:01:03]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-10-03 01:03:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/23439004/25001

[commit-bot: I haz the power, 2013-10-03 01:04:00]

Failed to apply patch for Source/core/animation/AnimatableNumberTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/core/animation/AnimatableNumberTest.cpp
  |diff --git a/Source/core/animation/AnimatableNumberTest.cpp
b/Source/core/animation/AnimatableNumberTest.cpp
  |index
48729192f73bad5579e12aa4698e32e9e23695aa..8df4ae7e04ae7521b829e2789a7e6e2b41569448
100644
  |--- a/Source/core/animation/AnimatableNumberTest.cpp
  |+++ b/Source/core/animation/AnimatableNumberTest.cpp
  --------------------------
  No file to patch.  Skipping patch.
  4 out of 4 hunks ignored

Patch:       Source/core/animation/AnimatableNumberTest.cpp
Index: Source/core/animation/AnimatableNumberTest.cpp
diff --git a/Source/core/animation/AnimatableNumberTest.cpp
b/Source/core/animation/AnimatableNumberTest.cpp
index
48729192f73bad5579e12aa4698e32e9e23695aa..8df4ae7e04ae7521b829e2789a7e6e2b41569448
100644
--- a/Source/core/animation/AnimatableNumberTest.cpp
+++ b/Source/core/animation/AnimatableNumberTest.cpp
@@ -216,7 +216,7 @@ TEST_F(AnimatableNumberTest, ToLength)
     EXPECT_EQ(
         Length(CalculationValue::create(
             adoptPtr(new CalcExpressionBinaryOperation(
-                adoptPtr(new CalcExpressionNumber(-5)),
+                adoptPtr(new CalcExpressionLength(Length(-5, WebCore::Fixed))),
                 adoptPtr(new CalcExpressionLength(Length(-5, Percent))),
                 CalcAdd)),
             CalculationRangeAll)),
@@ -224,7 +224,7 @@ TEST_F(AnimatableNumberTest, ToLength)
     EXPECT_EQ(
         Length(CalculationValue::create(
             adoptPtr(new CalcExpressionBinaryOperation(
-                adoptPtr(new CalcExpressionNumber(-15)),
+                adoptPtr(new CalcExpressionLength(Length(-15,
WebCore::Fixed))),
                 adoptPtr(new CalcExpressionLength(Length(-5, Percent))),
                 CalcAdd)),
             CalculationRangeAll)),
@@ -232,7 +232,7 @@ TEST_F(AnimatableNumberTest, ToLength)
     EXPECT_EQ(
         Length(CalculationValue::create(
             adoptPtr(new CalcExpressionBinaryOperation(
-                adoptPtr(new CalcExpressionNumber(-5)),
+                adoptPtr(new CalcExpressionLength(Length(-5, WebCore::Fixed))),
                 adoptPtr(new CalcExpressionLength(Length(-5, Percent))),
                 CalcAdd)),
             CalculationRangeNonNegative)),
@@ -240,7 +240,7 @@ TEST_F(AnimatableNumberTest, ToLength)
     EXPECT_EQ(
         Length(CalculationValue::create(
             adoptPtr(new CalcExpressionBinaryOperation(
-                adoptPtr(new CalcExpressionNumber(-15)),
+                adoptPtr(new CalcExpressionLength(Length(-15,
WebCore::Fixed))),
                 adoptPtr(new CalcExpressionLength(Length(-5, Percent))),
                 CalcAdd)),
             CalculationRangeNonNegative)),

[commit-bot: I haz the power, 2013-10-03 01:11:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/23439004/29001

[commit-bot: I haz the power, 2013-10-03 05:38:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/23439004/29001

[commit-bot: I haz the power, 2013-10-03 09:00:59]

Change committed as 158790