Source/core/animation/AnimatableLengthTest.cpp - Issue 23439004: CSS Calc: Use Lengths instead of numbers to represent pixels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimatableLengthTest.cpp

Issue 23439004: CSS Calc: Use Lengths instead of numbers to represent pixels (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased to ToT again Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/AnimatableLengthTest.cpp

diff --git a/Source/core/animation/AnimatableLengthTest.cpp b/Source/core/animation/AnimatableLengthTest.cpp

index c2d49a2685d5b1ab53e02e38dcd50bdf84c2df53..d10615a729f1a0b51af09cb6f31456c982fe8537 100644

--- a/Source/core/animation/AnimatableLengthTest.cpp

+++ b/Source/core/animation/AnimatableLengthTest.cpp

@@ -175,7 +175,7 @@ TEST_F(AnimatableLengthTest, ToLength)

EXPECT_EQ(

Length(CalculationValue::create(

adoptPtr(new CalcExpressionBinaryOperation(

- adoptPtr(new CalcExpressionNumber(-5)),

+ adoptPtr(new CalcExpressionLength(Length(-5, WebCore::Fixed))),

adoptPtr(new CalcExpressionLength(Length(-5, Percent))),

CalcAdd)),

CalculationRangeAll)),

@@ -183,7 +183,7 @@ TEST_F(AnimatableLengthTest, ToLength)

EXPECT_EQ(

Length(CalculationValue::create(

adoptPtr(new CalcExpressionBinaryOperation(

- adoptPtr(new CalcExpressionNumber(-15)),

+ adoptPtr(new CalcExpressionLength(Length(-15, WebCore::Fixed))),

adoptPtr(new CalcExpressionLength(Length(-5, Percent))),

CalcAdd)),

CalculationRangeAll)),

@@ -191,7 +191,7 @@ TEST_F(AnimatableLengthTest, ToLength)

EXPECT_EQ(

Length(CalculationValue::create(

adoptPtr(new CalcExpressionBinaryOperation(

- adoptPtr(new CalcExpressionNumber(-5)),

+ adoptPtr(new CalcExpressionLength(Length(-5, WebCore::Fixed))),

adoptPtr(new CalcExpressionLength(Length(-5, Percent))),

CalcAdd)),

CalculationRangeNonNegative)),

@@ -199,7 +199,7 @@ TEST_F(AnimatableLengthTest, ToLength)

EXPECT_EQ(

Length(CalculationValue::create(

adoptPtr(new CalcExpressionBinaryOperation(

- adoptPtr(new CalcExpressionNumber(-15)),

+ adoptPtr(new CalcExpressionLength(Length(-15, WebCore::Fixed))),

adoptPtr(new CalcExpressionLength(Length(-5, Percent))),

CalcAdd)),

CalculationRangeNonNegative)),

« no previous file with comments | « no previous file | Source/core/css/CSSCalculationValue.cpp » ('j') | no next file with comments »