Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2343863003: gpu/config: Add workaround rewrite do-while on Mac < 10.11 (Closed)

Created:
4 years, 3 months ago by Corentin Wallez
Modified:
4 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/config: Add workaround rewrite do-while on Mac < 10.11 BUG=644669 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d4d44f9ccbce0cd089a3066c438952863921cd40 Cr-Commit-Position: refs/heads/master@{#419171}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +16 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Corentin Wallez
PTAL, this should fix the do-while issues on the Mac minis
4 years, 3 months ago (2016-09-15 17:47:08 UTC) #3
Ken Russell (switch to Gerrit)
Sorry for the delay reviewing this and thanks for putting it together. LGTM though I ...
4 years, 3 months ago (2016-09-16 00:05:55 UTC) #4
Corentin Wallez
On 2016/09/16 at 00:05:55, kbr wrote: > Sorry for the delay reviewing this and thanks ...
4 years, 3 months ago (2016-09-16 14:16:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343863003/20001
4 years, 3 months ago (2016-09-16 14:17:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 15:11:09 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 15:14:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4d44f9ccbce0cd089a3066c438952863921cd40
Cr-Commit-Position: refs/heads/master@{#419171}

Powered by Google App Engine
This is Rietveld 408576698