Convert fast/canvas Layouttests to testharness

Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732
Committed: https://crrev.com/52d02d1939ccec2075a812b5095c80765c54c22b
Cr-Commit-Position: refs/heads/master@{#419370}

[Abhishek Kanike, 2016-09-15 05:17:20]

Description was changed from

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transformed reset.

BUG=639732
==========

to

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transformed reset.

BUG=639732
==========

[Abhishek Kanike, 2016-09-15 05:17:20]

abhishek.ka@samsung.com changed reviewers:
+ siva.gunturi@samsung.com, srirama.m@samsung.com

[sivag, 2016-09-15 05:31:14]

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/script-tests/translate-text.js
(left):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/script-tests/translate-text.js:1:
description("Test for chromium's canvas bug where fillText resets the current
context https://bugs.webkit.org/show_bug.cgi?id=26436 . You must see green box
with message 'This text should be seen', and black box below the green box.")
May be you can keep the bug-id part and description as a comment in html file.

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html
(right):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html:2:
<title>Test for chromium's canvas on transform property and reset the current
context</title>
are we still resetting the current context?

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/translate-text.html (right):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:10: return "[" +
p[0] + ", " + p[1] + ", " + p[2] + ", " + p[3] + "]"
maintain indentation

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:33: // Pixel
value at 0, 0
maintain indentation

[Srirama, 2016-09-15 09:29:55]

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html
(right):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html:3:
<script src="../../resources/testharness.js"></script>
i think we can leave this test as it is, as it doesn't use js-test framework
(you can focus only on the tests which use js-test framework). Also we should
not remove dumpAsText as that is only thing tested here.

[Abhishek Kanike, 2016-09-15 11:52:56]

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/script-tests/translate-text.js
(left):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/script-tests/translate-text.js:1:
description("Test for chromium's canvas bug where fillText resets the current
context https://bugs.webkit.org/show_bug.cgi?id=26436 . You must see green box
with message 'This text should be seen', and black box below the green box.")
On 2016/09/15 05:31:14, sivag wrote:
> May be you can keep the bug-id part and description as a comment in html file.

Done.

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html
(right):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html:2:
<title>Test for chromium's canvas on transform property and reset the current
context</title>
On 2016/09/15 05:31:14, sivag wrote:
> are we still resetting the current context?

Sorry the title is misleading. We are not reseting the context.

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html:3:
<script src="../../resources/testharness.js"></script>
On 2016/09/15 09:29:55, Srirama wrote:
> i think we can leave this test as it is, as it doesn't use js-test framework
> (you can focus only on the tests which use js-test framework). Also we should
> not remove dumpAsText as that is only thing tested here.

Yes we are not using the js-test framework. But keeping this change for now by
adding the dumpAsText

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/translate-text.html (right):

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:10: return "[" +
p[0] + ", " + p[1] + ", " + p[2] + ", " + p[3] + "]"
On 2016/09/15 05:31:14, sivag wrote:
> maintain indentation

Done.

https://codereview.chromium.org/2343793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:33: // Pixel
value at 0, 0
On 2016/09/15 05:31:14, sivag wrote:
> maintain indentation

Done.

[Abhishek Kanike, 2016-09-16 04:03:11]

Description was changed from

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transformed reset.

BUG=639732
==========

to

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732
==========

[Abhishek Kanike, 2016-09-16 04:04:23]

abhishek.ka@samsung.com changed reviewers:
+ fs@opera.com, junov@chromium.org

[Abhishek Kanike, 2016-09-16 06:12:45]

abhishek.ka@samsung.com changed reviewers:
- fs@opera.com, junov@chromium.org

[Srirama, 2016-09-16 06:58:43]

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html (left):

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html:7: <script
src="script-tests/text-globalAlpha.js"></script>
I think it is not used anywhere else, so you can remove this file as well.

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html (right):

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html:14: var
imageData = ctx.getImageData(63, 22, 1, 1);
combine these two stmts.
var imageData = ctx.getImageData(63, 22, 1, 1).data;
and use imageData directly below.

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/translate-text.html (right):

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:37: var imageData
= ctx.getImageData(0, 0, 1, 1);
same here also,
var pixelData = ctx.getImageData(0, 0, 1, 1).data;

[Abhishek Kanike, 2016-09-16 08:53:41]

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html (left):

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html:7: <script
src="script-tests/text-globalAlpha.js"></script>
On 2016/09/16 06:58:43, Srirama wrote:
> I think it is not used anywhere else, so you can remove this file as well.

Done.

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html (right):

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/text-globalAlpha.html:14: var
imageData = ctx.getImageData(63, 22, 1, 1);
On 2016/09/16 06:58:43, Srirama wrote:
> combine these two stmts.
> var imageData = ctx.getImageData(63, 22, 1, 1).data;
> and use imageData directly below.

Done.

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/translate-text.html (right):

https://codereview.chromium.org/2343793002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:37: var imageData
= ctx.getImageData(0, 0, 1, 1);
On 2016/09/16 06:58:43, Srirama wrote:
> same here also,
> var pixelData = ctx.getImageData(0, 0, 1, 1).data;

Done.

[Srirama, 2016-09-16 08:54:28]

lgtm

[Srirama, 2016-09-16 08:54:31]

lgtm

[Abhishek Kanike, 2016-09-16 08:55:54]

abhishek.ka@samsung.com changed reviewers:
+ fs@opera.com, junov@chromium.org

[fs, 2016-09-16 14:30:31]

LGTM w/ nits

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/translate-text.html (right):

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:2: <title>Test
for chromium's canvas bug where fillText resets the current context</title>
Maybe drop "chromium's" here.

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:8: // Chromium
Bug: https://bugs.webkit.org/show_bug.cgi?id=26436.
And "Chromium" here.

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:39:
assert_equals(pixelToString(pixel), "[0, 255, 0, 255]");
assert_array_equals rather than going to string?

[Abhishek Kanike, 2016-09-17 02:28:10]

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/translate-text.html (right):

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:2: <title>Test
for chromium's canvas bug where fillText resets the current context</title>
On 2016/09/16 14:30:31, fs wrote:
> Maybe drop "chromium's" here.

Done.

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:8: // Chromium
Bug: https://bugs.webkit.org/show_bug.cgi?id=26436.
On 2016/09/16 14:30:31, fs wrote:
> And "Chromium" here.

Done.

https://codereview.chromium.org/2343793002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/translate-text.html:39:
assert_equals(pixelToString(pixel), "[0, 255, 0, 255]");
On 2016/09/16 14:30:31, fs wrote:
> assert_array_equals rather than going to string?

Done.

[Abhishek Kanike, 2016-09-17 02:31:45]

The CQ bit was checked by abhishek.ka@samsung.com

[Abhishek Kanike, 2016-09-17 02:31:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
srirama.m@samsung.com, fs@opera.com
Link to the patchset: https://codereview.chromium.org/2343793002/#ps100001
(title: "Refactor3")

[Abhishek Kanike, 2016-09-17 02:31:48]

The CQ bit was unchecked by abhishek.ka@samsung.com

[Abhishek Kanike, 2016-09-17 02:33:09]

The CQ bit was checked by abhishek.ka@samsung.com

[commit-bot: I haz the power, 2016-09-17 02:33:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 03:45:18]

Description was changed from

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732
==========

to

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732
==========

[commit-bot: I haz the power, 2016-09-17 03:45:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-17 03:48:59]

Description was changed from

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732
==========

to

==========
Convert fast/canvas Layouttests to testharness

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732

Committed: https://crrev.com/52d02d1939ccec2075a812b5095c80765c54c22b
Cr-Commit-Position: refs/heads/master@{#419370}
==========

[commit-bot: I haz the power, 2016-09-17 03:49:00]

Patchset 6 (id:??) landed as
https://crrev.com/52d02d1939ccec2075a812b5095c80765c54c22b
Cr-Commit-Position: refs/heads/master@{#419370}