third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html - Issue 2343793002: Convert fast/canvas Layouttests to testharness

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset.html

Issue 2343793002: Convert fast/canvas Layouttests to testharness (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/canvas/script-tests/translate-text.js ('K') | « third_party/WebKit/LayoutTests/fast/canvas/script-tests/translate-text.js ('k') | third_party/WebKit/LayoutTests/fast/canvas/transformed-canvas-reset-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/canvas/translate-text.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <canvas id="can" width=200 height=256 style="transform: translateZ(0)"></canvas>	2 <title>Test for chromium's canvas on transform property and reset the current co ntext</title>
	sivag 2016/09/15 05:31:14 are we still resetting the current context? are we still resetting the current context? Abhishek Kanike 2016/09/15 11:52:56 Sorry the title is misleading. We are not reseting Show quoted text On 2016/09/15 05:31:14, sivag wrote: > are we still resetting the current context? Sorry the title is misleading. We are not reseting the context.
3 Test passes if DRT doesn't crash.	3 <script src="../../resources/testharness.js"></script>
	Srirama 2016/09/15 09:29:55 i think we can leave this test as it is, as it doe i think we can leave this test as it is, as it doesn't use js-test framework (you can focus only on the tests which use js-test framework). Also we should not remove dumpAsText as that is only thing tested here. Abhishek Kanike 2016/09/15 11:52:56 Yes we are not using the js-test framework. But ke Show quoted text On 2016/09/15 09:29:55, Srirama wrote: > i think we can leave this test as it is, as it doesn't use js-test framework > (you can focus only on the tests which use js-test framework). Also we should > not remove dumpAsText as that is only thing tested here. Yes we are not using the js-test framework. But keeping this change for now by adding the dumpAsText
	4 <script src="../../resources/testharnessreport.js"></script>

	5

	6 <canvas width=200 height=256 style="transform: translateZ(0)"></canvas>

4 <script>	7 <script>

5 var can = document.querySelector("#can");	8 test(function() {

6 var ctx = can.getContext("2d");	9 var can = document.querySelector("canvas");

7 ctx.fillStyle = "green";	10 var ctx = can.getContext("2d");

8 ctx.fillRect(0, 0, 300, 300);	11 ctx.fillStyle = "green";

9 document.body.offsetTop;	12 ctx.fillRect(0, 0, 300, 300);

10 can.width = 300;	13 document.body.offsetTop;

11 if (window.testRunner)	14 can.width = 300;

12 testRunner.dumpAsText();	15 });

13 </script>	16 </script>

OLD	NEW