Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2343753002: [ios] Fixed getUnownedAutofillableFormFieldElements_. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed getUnownedAutofillableFormFieldElements_. Push element to |fieldsets| instead of |fieldset|. BUG=487804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/autofill/ios/browser/resources/autofill_controller.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-09-15 00:37:24 UTC) #3
Lei Zhang
lgtm, doh.
4 years, 3 months ago (2016-09-20 01:41:46 UTC) #4
Eugene But (OOO till 7-30)
Thanks!
4 years, 3 months ago (2016-09-20 01:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343753002/1
4 years, 3 months ago (2016-09-20 01:59:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262603)
4 years, 3 months ago (2016-09-20 02:06:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343753002/1
4 years, 3 months ago (2016-09-20 02:09:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262609)
4 years, 3 months ago (2016-09-20 02:17:29 UTC) #13
Lei Zhang
Uh, https://codereview.chromium.org/2343013005 beat you to it.
4 years, 3 months ago (2016-09-20 02:36:47 UTC) #14
Lei Zhang
On 2016/09/20 02:36:47, Lei Zhang wrote: > Uh, https://codereview.chromium.org/2343013005 beat you to it. Should have ...
4 years, 3 months ago (2016-09-20 02:38:11 UTC) #15
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-09-20 03:03:26 UTC) #16 
On 2016/09/20 02:38:11, Lei Zhang wrote:
> On 2016/09/20 02:36:47, Lei Zhang wrote:
> > Uh, https://codereview.chromium.org/2343013005 beat you to it.
> 
> Should have asked Justin, since my code review name said OOO all last week.
:-P
That's ok :) Thanks!

Powered by Google App Engine
This is Rietveld 408576698